#2309737: Remove deprecated format_plural usage. Now, let's remove the function itself.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Prioritized changes The main goal of this issue is removing previously deprecated code.
CommentFileSizeAuthor
#9 remove_format_plural-2366539-9.patch2.47 KBianthomas_uk
#1 drupal-remove-format-plural-2366539.patch2.83 KBmax-kuzomko

Comments

max-kuzomko’s picture

max-kuzomko commented
StatusFileSize
new drupal-remove-format-plural-2366539.patch2.83 KB

This patch removes format_plural().

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Postponed » Needs review

bot status

Status: Needs review » Needs work

The last submitted patch, 1: drupal-remove-format-plural-2366539.patch, failed testing.

Status: Needs work » Needs review

mirom queued 1: drupal-remove-format-plural-2366539.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-remove-format-plural-2366539.patch, failed testing.

mirom’s picture

mirom commented

You have bug in your patch. Following lines shouldn't be removed:

-/**
  * Generates a string representation for the given byte count.
  *
  * @param $size

You have also some crazy code in the beginning of the file.

From 465eefa50f78e8ef14ec81da64b1d80339f9286f Mon Sep 17 00:00:00 2001
From: Maksym Kuzomko <max@smartweb-studio.com>
Date: Sun, 2 Nov 2014 15:08:02 +0200
Subject: [PATCH] https://www.drupal.org/node/2366539 #2366539: Remove
 format_plural().

---
 drupal/core/includes/common.inc | 53 -----------------------------------------
 1 file changed, 53 deletions(-)
mirom’s picture

mirom commented
Assigned: Unassigned » mirom
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Postponed

First must be fixed #2309737: Remove deprecated format_plural usage.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Assigned: mirom » Unassigned
Status: Postponed » Needs review
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
StatusFileSize
new remove_format_plural-2366539-9.patch2.47 KB

The usage issue has now been committed, so this is unblocked.

LinL’s picture

LinL commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +@deprecated

Change record is done and this is the only occurrence of format_plural() remaining so RTBC.

LinL’s picture

LinL commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3df1005 and pushed to 8.0.x. Thanks!

  • alexpott committed 3df1005 on 8.0.x 
    Issue #2366539 by max-kuzomko, ianthomas_uk: Remove format_plural()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.