There seems to be a small mistake in the bartik layout.css file as where the definition for the width and margin of the sidebars in a one sidebar layout for media style 560 to 850 px.
In the css file the class is given with .one-sidebar where as the html delivers .layout-one-sidebar. So the style gets not applied here.
I attach a small patch for the layout.css to remedy this issue.
| Unfrozen changes | Unfrozen because it only changes CSS. |
|---|
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | bartik-after-patch.png | 110.94 KB | emma.maria |
| #3 | bartik-before-patch.png | 95.72 KB | emma.maria |
| #1 | CSS definition for one sidebar and 560 to 850 px not correct-2365653-1.patch | 716 bytes | stefan.korn |
Comments
Comment #1
stefan.kornComment #2
emma.mariaSetting this issue to Needs review to fire tests for the patch, I will look into this issue in the meantime.
Comment #3
emma.mariaExcellent spot! The class had not been updated in that section of layout.css so that part of the CSS styling was lost to Bartik.
Before the patch:
The sidebars jumped from 100% to 50% at 560px - 850px for no reason as there was nothing beside them.
After the patch:
Bartik inherits the styles that the incorrect class missed out :)
Comment #4
emma.mariaComment #5
emma.mariaComment #6
dries commentedNice catch and thanks for the fix. Committed!