Utterly minor, but I thought I'd post it since I noticed it...

I couldn't stand it anymore and just set comments to be read-only over at #79018: protect Drupal core .txt files

However, when you view the issue, there's still a quick-link to "Add new comment" even though there's no comment form on the page or any way to add a new comment.

CommentFileSizeAuthor
#3 236459_pi_add_comment_3.patch3.9 KBaclight
#2 add_comment_links.patch3.65 KBhunmonk
#1 236459_pi_add_comment_1.patch3.19 KBaclight

Comments

aclight’s picture

aclight commented
Status: Active » Needs review
StatusFileSize
new 236459_pi_add_comment_1.patch3.19 KB

Here's a patch that fixes the problem. I also noticed that if comments were disabled for an issue (instead of just set to be read only), the Most recent comment/First unread comment link was still showing up, so this patch fixes that problem as well.

hunmonk’s picture

hunmonk commented
StatusFileSize
new add_comment_links.patch3.65 KB

i believe the link for most recent file attachment needs to go in there as well. attached patch corrects this, and has been tested as working for all node comment settings.

aclight’s picture

aclight commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 236459_pi_add_comment_3.patch3.9 KB

Yep, good catch. Code looks good and this works as intended. I've rerolled the patch to eliminate the offset, but otherwise didn't change anything.

hunmonk’s picture

hunmonk commented
Status: Reviewed & tested by the community » Fixed

committed to 5.x-2.x and 5.x-3.x, deployed on d.o et. all.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.