Found a small bug inside FeedsCSVParser.inc: FeedsCSVParser::sourceForm(), this function calls for format_plural with already translated arguments, and this is no good.

I'am talking about this 134 line:

$items[] = format_plural(count($uniques), t('Column <strong>!column</strong> is mandatory and considered unique: only one item per !column value will be created.', array('!column' => implode(', ', $uniques))), t('Columns <strong>!columns</strong> are mandatory and values in these columns are considered unique: only one entry per value in one of these column will be created.', array('!columns' => implode(', ', $uniques))));

It should be fixed as this:

$items[] = format_plural(count($uniques), 'Column <strong>!columns</strong> is mandatory and considered unique: only one item per !column value will be created.', 'Columns <strong>!columns</strong> are mandatory and values in these columns are considered unique: only one entry per value in one of these column will be created.', array('!columns' => implode(', ', $uniques)));

Comments

Niremizov’s picture

Issue summary: View changes
Niremizov’s picture

Status: Active » Needs review
StatusFileSize
new1.41 KB

Patch attached.

megachriz’s picture

Status: Needs review » Reviewed & tested by the community

Good find. Patch looks good.

  • twistor committed 6df3463 on 7.x-2.x authored by Niremizov
    Issue #2363779 by Niremizov, MegaChriz: CSVParser Source form...
twistor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.