Found a small bug inside FeedsCSVParser.inc: FeedsCSVParser::sourceForm(), this function calls for format_plural with already translated arguments, and this is no good.
I'am talking about this 134 line:
$items[] = format_plural(count($uniques), t('Column <strong>!column</strong> is mandatory and considered unique: only one item per !column value will be created.', array('!column' => implode(', ', $uniques))), t('Columns <strong>!columns</strong> are mandatory and values in these columns are considered unique: only one entry per value in one of these column will be created.', array('!columns' => implode(', ', $uniques))));
It should be fixed as this:
$items[] = format_plural(count($uniques), 'Column <strong>!columns</strong> is mandatory and considered unique: only one item per !column value will be created.', 'Columns <strong>!columns</strong> are mandatory and values in these columns are considered unique: only one entry per value in one of these column will be created.', array('!columns' => implode(', ', $uniques)));
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | CSVParser_translation_fix-2363779-2.patch | 1.41 KB | Niremizov |
Comments
Comment #1
Niremizov commentedComment #2
Niremizov commentedPatch attached.
Comment #3
megachrizGood find. Patch looks good.
Comment #5
twistor commented