Add drupalorg specific implementation new hook_versioncontrol_project_issue_git_issue_notification_project_issue_nids_alter().

CommentFileSizeAuthor
#1 interdiff.txt3.26 KBmarvil07
#1 0001-Issue-2363121-Restrict-action-into-issues-after-vers.patch2.1 KBmarvil07

Comments

marvil07’s picture

marvil07 commented
Title: Implement new hook_versioncontrol_project_issue_git_issue_notification_project_issue_nids_alter() » Restrict action into issues after versioncontrol_project_issue_git event processors
Issue summary: View changes
StatusFileSize
new 0001-Issue-2363121-Restrict-action-into-issues-after-vers.patch2.1 KB
new interdiff.txt3.26 KB

Since the patch posted on the related issue I implemented the "if issue nid in the branch name" case, and also followed the changes about the hook rename and its modifications.

@drumm, IIRC project node itself have the valid release pattern, so this probably can be improved a little, so it less hardcoded, hopefully you want to jump into it.

marvil07’s picture

marvil07 commented
Assigned: marvil07 » Unassigned
Status: Active » Needs review

  • marvil07 committed 4cff0f9 on restrict-commit-issue-notifications 
    Issue #2363121: Restrict action into issues after...
drumm’s picture

drumm
he/him
Location NY, US
commented

IIRC project node itself have the valid release pattern, so this probably can be improved a little, so it less hardcoded, hopefully you want to jump into it.

It does, but DrupalorgVersioncontrolLabelVersionMapperGit.class.php has the final say.

marvil07’s picture

marvil07 commented
Status: Needs review » Reviewed & tested by the community

Then I will add it directly to 7.x-3.x.

I guess we could instanciate the plugin an run some methods with the passed refname and verify is not false, but I thin kthis shoul dbe ok for now.

  • marvil07 committed 4cff0f9 on 7.x-3.x 
    Issue #2363121: Restrict action into issues after...
marvil07’s picture

marvil07 commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +needs drupal.org deployment

Adding tag

  • drumm committed 5016f44 on 7.x-3.x, restrict-commit-issue-notifications 
    #2363121 Quote regexp.
  • drumm committed bda46b7 on 7.x-3.x, restrict-commit-issue-notifications
    #2363121 More-simple project loading.
  • drumm committed 5016f44 on 7.x-3.x, restrict-commit-issue-notifications
    #2363121 Quote regexp.
  • drumm committed bda46b7 on 7.x-3.x, restrict-commit-issue-notifications
    #2363121 More-simple project loading.
drumm’s picture

drumm
he/him
Location NY, US
commented

I added 2 small changes:

Quoting the regexp is unnecessary, but good to do.

Loading the project already had a node ID, so using node_load().

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: -needs drupal.org deployment

Now deployed and confirmed working.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.