Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Add drupalorg specific implementation new hook_versioncontrol_project_issue_git_issue_notification_project_issue_nids_alter()
.
Comment | File | Size | Author |
---|---|---|---|
#1 | interdiff.txt | 3.26 KB | marvil07 |
#1 | 0001-Issue-2363121-Restrict-action-into-issues-after-vers.patch | 2.1 KB | marvil07 |
Comments
Comment #1
marvil07 CreditAttribution: marvil07 commentedSince the patch posted on the related issue I implemented the "if issue nid in the branch name" case, and also followed the changes about the hook rename and its modifications.
@drumm, IIRC project node itself have the valid release pattern, so this probably can be improved a little, so it less hardcoded, hopefully you want to jump into it.
Comment #2
marvil07 CreditAttribution: marvil07 commentedComment #4
drummIt does, but
DrupalorgVersioncontrolLabelVersionMapperGit.class.php
has the final say.Comment #5
marvil07 CreditAttribution: marvil07 commentedThen I will add it directly to 7.x-3.x.
I guess we could instanciate the plugin an run some methods with the passed refname and verify is not false, but I thin kthis shoul dbe ok for now.
Comment #7
marvil07 CreditAttribution: marvil07 commentedAdding tag
Comment #9
drummI added 2 small changes:
Quoting the regexp is unnecessary, but good to do.
Loading the project already had a node ID, so using
node_load()
.Comment #10
drummNow deployed and confirmed working.