Closed (fixed)
Project:
Configuration Tools
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Oct 2014 at 22:23 UTC
Updated:
10 Dec 2021 at 17:19 UTC
Jump to comment: Most recent
Comments
Comment #1
eclipsegc commentedLOC 29, 31, 55 & 57 of GitConfigEvents are the only places its used, and yes you're correct we are making a potentially hazardous assumption that the git_url lines up with the remote in the git repository already in the directory (all sorts of assumptions there).
Super open to discussing how to better set this up.
Eclipse
Comment #2
moshe weitzman commentedRight, the only code is for managing the config property. It isn't used in any other code. I think you could just get rid of this config property.
Comment #3
eclipsegc commentedOne of the features I'd like to add to it is the ability to parse tags in the repo and deploy those via the normal "import" of config. This would give us the ability to essentially tag known "good" configurations.
Comment #4
avpadernoThe cpliakas/git-wrapper library allows to get the tags associated with the local repository without requiring the Git URL. There isn't any method to get all the tags in the remote repository knowing its Git URL; that would require cloning a specific branch and get the tag list from the local copy.
I would rather remove that configuration value, as I don't see any use of it, except in the case we want to allow users to clone the remote repository from the module.
Comment #5
avpadernoI am changing it to a task for the 2.0.x (Drupal 9) branch.
Comment #7
avpadernoComment #9
avpaderno