I don't see anywhere that girl_url config item is used. I might be missing it. It looks like we are assuming that the repo at $active_dir already has an origin defined.

Comments

eclipsegc’s picture

LOC 29, 31, 55 & 57 of GitConfigEvents are the only places its used, and yes you're correct we are making a potentially hazardous assumption that the git_url lines up with the remote in the git repository already in the directory (all sorts of assumptions there).

Super open to discussing how to better set this up.

Eclipse

moshe weitzman’s picture

Right, the only code is for managing the config property. It isn't used in any other code. I think you could just get rid of this config property.

eclipsegc’s picture

One of the features I'd like to add to it is the ability to parse tags in the repo and deploy those via the normal "import" of config. This would give us the ability to essentially tag known "good" configurations.

avpaderno’s picture

The cpliakas/git-wrapper library allows to get the tags associated with the local repository without requiring the Git URL. There isn't any method to get all the tags in the remote repository knowing its Git URL; that would require cloning a specific branch and get the tag list from the local copy.

I would rather remove that configuration value, as I don't see any use of it, except in the case we want to allow users to clone the remote repository from the module.

avpaderno’s picture

Title: git_url is not used? » Remove the git_url setting
Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: moshe weitzman » Unassigned
Category: Bug report » Task

I am changing it to a task for the 2.0.x (Drupal 9) branch.

  • apaderno committed 7fc9ff5 on 2.0.x
    Issue #2362711 by moshe weitzman, EclipseGc, apaderno: Remove the...
avpaderno’s picture

Status: Active » Fixed

  • apaderno committed a5de28c on 8.x-1.x
    Issue #2362711 by apaderno, EclipseGc, moshe weitzman: Remove the...
avpaderno’s picture

Version: 2.0.x-dev » 8.x-1.x-dev

  • apaderno committed c0332ab on 8.x-1.x
    Issue #2362711 by apaderno, EclipseGc, moshe weitzman: Remove the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.