Comments

rpayanm’s picture

rpayanm’s picture

Status: Active » Needs review
StatusFileSize
new59.02 KB

Status: Needs review » Needs work

The last submitted patch, 2: 2361823-2.patch, failed testing.

rpayanm’s picture

Status: Needs work » Needs review
StatusFileSize
new59.16 KB
rpayanm’s picture

Assigned: rpayanm » Unassigned
javivf’s picture

StatusFileSize
new58.98 KB

I had to do a reroll and i haven't found the function, only the declaration in file core/includes/unicode.inc. Maybe this can be removed.

Status: Needs review » Needs work

The last submitted patch, 6: 2361823-6.patch, failed testing.

rpayanm queued 4: 2361823-4.patch for re-testing.

penyaskito’s picture

+++ b/core/modules/block_content/src/Tests/BlockContentCreationTest.php
@@ -165,7 +165,7 @@ public function testBlockDelete() {
+      'id' => Unicode::strlower($edit['info[0][value]']),

Must be str*TO*lower

The last submitted patch, 4: 2361823-4.patch, failed testing.

javivf’s picture

Status: Needs work » Needs review
StatusFileSize
new58.98 KB

Typo solved, thanks penyaskito

rpayanm queued 11: 2361823-11.patch for re-testing.

rpayanm’s picture

Status: Needs review » Reviewed & tested by the community

No occurrences found for drupal_strtolower().

alexpott’s picture

We need to consider the disruption of this patch and we might need to update #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? wrt to removing already deprecated functions.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Needs a reroll

git ac https://www.drupal.org/files/issues/2361823-11.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 60396  100 60396    0     0  49985      0  0:00:01  0:00:01 --:--:-- 50881
error: patch failed: core/modules/search/search.module:244
error: core/modules/search/search.module: patch does not apply
rpayanm’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new58.6 KB
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (deprecate function removal) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 80eccb1 and pushed to 8.0.x. Thanks!

M  core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
M  core/modules/color/color.module
M  core/modules/entity_reference/src/EntityReferenceController.php
M  core/modules/search/search.module
M  core/modules/update/update.report.inc

Whilst on size this patch appears disruptive - the majority of changes are to tests. Above is a list of the non test parts of the patch. That's out of 52 files changing.

  • alexpott committed 80eccb1 on 8.0.x
    Issue #2361823 by rpayanm, javivf: Remove usage of drupal_strtolower().
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.