| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2361823-16.patch | 58.6 KB | rpayanm |
| #11 | 2361823-11.patch | 58.98 KB | javivf |
| #4 | 2361823-4.patch | 59.16 KB | rpayanm |
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2361823-16.patch | 58.6 KB | rpayanm |
| #11 | 2361823-11.patch | 58.98 KB | javivf |
| #4 | 2361823-4.patch | 59.16 KB | rpayanm |
Comments
Comment #1
rpayanmComment #2
rpayanmComment #4
rpayanmComment #5
rpayanmComment #6
javivf commentedI had to do a reroll and i haven't found the function, only the declaration in file core/includes/unicode.inc. Maybe this can be removed.
Comment #9
penyaskitoMust be str*TO*lower
Comment #11
javivf commentedTypo solved, thanks penyaskito
Comment #13
rpayanmNo occurrences found for drupal_strtolower().
Comment #14
alexpottWe need to consider the disruption of this patch and we might need to update #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? wrt to removing already deprecated functions.
Comment #15
alexpottNeeds a reroll
Comment #16
rpayanmComment #17
aspilicious commentedComment #18
alexpottThis issue is a prioritized change (deprecate function removal) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 80eccb1 and pushed to 8.0.x. Thanks!
Whilst on size this patch appears disruptive - the majority of changes are to tests. Above is a list of the non test parts of the patch. That's out of 52 files changing.