Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#8 | 2361745-8.patch | 11.14 KB | rpayanm |
#4 | 2361745-3.patch | 27.33 KB | javivf |
#1 | 2361745-1.patch | 11.33 KB | rpayanm |
Comments
Comment #1
rpayanmComment #2
rpayanmComment #3
javivf CreditAttribution: javivf commentedThe patch applies now
Comment #4
javivf CreditAttribution: javivf commentedComment #6
filijonka CreditAttribution: filijonka commentedhi
I'm a bit confused here why this second patch appears? The issue is to replace all truncate_utf() which the first patch does, the second patch does a whole lot of other stuff to and there is no interdiff so hard to say what's going on.
Comment #7
filijonka CreditAttribution: filijonka commentedpathc #4 is interfering with this issue #2355187: Remove form_get_cache() so this patch is doing to much
Comment #8
rpayanmhere the reroll :)
Comment #9
filijonka CreditAttribution: filijonka commentedhi
1. This dunction isn't named in the meta but I assume it should be deprecated so it would perhaps be good if added to the meta-list
2. we still needs interdiffs so we know what's going on between the comments, see https://www.drupal.org/documentation/git/interdiff
Comment #10
JeroenTNo occurrences left and patch looks ok to me.
Comment #11
alexpottThis issue is a prioritized change (removal of deprecated code) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed ea325a9 and pushed to 8.0.x. Thanks!