Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rpayanm’s picture

Status: Active » Needs review
FileSize
11.33 KB
rpayanm’s picture

Assigned: rpayanm » Unassigned
javivf’s picture

The patch applies now

javivf’s picture

FileSize
27.33 KB

rpayanm queued 4: 2361745-3.patch for re-testing.

filijonka’s picture

hi

I'm a bit confused here why this second patch appears? The issue is to replace all truncate_utf() which the first patch does, the second patch does a whole lot of other stuff to and there is no interdiff so hard to say what's going on.

filijonka’s picture

Status: Needs review » Needs work

pathc #4 is interfering with this issue #2355187: Remove form_get_cache() so this patch is doing to much

rpayanm’s picture

Status: Needs work » Needs review
FileSize
11.14 KB

here the reroll :)

filijonka’s picture

hi

1. This dunction isn't named in the meta but I assume it should be deprecated so it would perhaps be good if added to the meta-list

2. we still needs interdiffs so we know what's going on between the comments, see https://www.drupal.org/documentation/git/interdiff

JeroenT’s picture

Status: Needs review » Reviewed & tested by the community

No occurrences left and patch looks ok to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (removal of deprecated code) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed ea325a9 and pushed to 8.0.x. Thanks!

  • alexpott committed ea325a9 on 8.0.x
    Issue #2361745 by rpayanm, javivf: Remove usage of truncate_utf8().
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.