The css file in core\modules\menu_ui\css is not loaded because the path given in MenuListBuilder.php and MenuForm.php is not correct.

I have created a small patch for this.

CommentFileSizeAuthor
#5 menu_ui _css_file_is_not loaded-2361599-5.patch1.62 KBstefan.korn
#3 menu_ui _css_file_is_not loaded-2361599-3.patch1.62 KBstefan.korn
#1 menu_ui _css_file_is_not loaded-2361599-0.patch1.25 KBstefan.korn

Comments

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
StatusFileSize
new menu_ui _css_file_is_not loaded-2361599-0.patch1.25 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Issue tags: +Quickfix

Good catch!

While we are here, can we add this css directly to a new entry in the menu_ui.libraries.yml and then attach the library instead?

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
StatusFileSize
new menu_ui _css_file_is_not loaded-2361599-3.patch1.62 KB

Yes, that would surely make sense.

How about this one?

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/menu_ui/menu_ui.libraries.yml
@@ -14,3 +14,9 @@ drupal.menu_ui.admin:
+drupal.menu_ui.adminforms:
...
+      css/menu_ui.admin.css: {}

Let's get rid of the whitespaces here, sorry :(

stefan.korn’s picture

stefan.korn
Primary language German
Location Jossgrund
commented
StatusFileSize
new menu_ui _css_file_is_not loaded-2361599-5.patch1.62 KB

Damn whitespaces are so invisble, always miss them ...

I think you mean white space at the end only, not those for indenting?

So let's try this one

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 796cec2 and pushed to 8.0.x. Thanks!

  • alexpott committed 796cec2 on 8.0.x 
    Issue #2361599 by stefan.korn: Fixed menu_ui css file is not loaded.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.