There's an issue with using this module with sites that also use varnish caching. Varnish will cache the node with the reference to the cpn stylesheet with a query string. Then when the node is updated, the updated query string isn't getting updated in the varnish cache.

CommentFileSizeAuthor
#4 interdiff-2361575-3-4.txt1.11 KBkepford
#4 cpn-n2361575-4.patch2.99 KBkepford
#3 cpn-n2361575-3.patch3.09 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.5 » 7.x-1.x-dev
kepford’s picture

kepford commented

I am seeing this issue as well on a Pantheon site.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new cpn-n2361575-3.patch3.09 KB

This is an updated version of a change kepford provided to me personally.

kepford’s picture

kepford commented
StatusFileSize
new cpn-n2361575-4.patch2.99 KB
new interdiff-2361575-3-4.txt1.11 KB

Did a little testing and cleaned up a few things.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@kepford: How has the patch been working for you?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed fd5ae04 on 7.x-1.x authored by kepford 
    Issue #2361575 by kepford, DamienMcKenna: Optionally load the CSS/JS as...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
Issue tags: +Needs backport to D6
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Fixed
Issue tags: -Needs backport to D6

The D6 module of this is no longer supported, so I'm closing this issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Closed (fixed)