Problem/Motivation

This is essentially the same as #1469362: Page cache never expires if page_cache_without_database is enabled but with a slight twist. Authcache 7.x-2.x does not work properly when page_cache_without_database is set (i.e. the core page cache interferes with Authcache) and therefore uses its own authcache_builtin_cache_without_database setting for the same purpose.

Proposed resolution

In order to support Authcache, the fix committed in #1469362 should be extended to cover that use-case also.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2361001-fix-page-cache-without-db.patch662 bytesznerol

Comments

znerol’s picture

znerol commented
Status: Active » Needs review
StatusFileSize
new 2361001-fix-page-cache-without-db.patch662 bytes

Instead of examining $GLOBALS['conf']['page_cache_without_database'], let's just test whether the necessary bootstrapping level was reached. This works for the core page cache as well as for Authcache.

jeremy’s picture

jeremy commented
Issue tags: +7.x-1.4 blocker

Looks straightforward; I need to test this and confirm it works as promised and with no penalty, and then would like to include it in the next release.

cthshabel’s picture

cthshabel commented

I will be testing this. I have been facing issues with memcached not clearing when authcache is enabled. I can help in some way testing if you all tell me what to look for?

  • Jeremy committed a2e9e38 on 7.x-1.x authored by znerol 
    Issue #2361001 by znerol: Page cache never expires if...
jeremy’s picture

jeremy commented
Status: Needs review » Fixed

Thanks! I also added a comment explaining why we don't call drupal_get_bootstrap_phase():
http://cgit.drupalcode.org/memcache/commit/?id=a2e9e38

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.