Hello,

This fix is a minor UI improvement to the default view.

Before:
Before the patch
After:
After the patch

Patch is attached.

Thanks!

CommentFileSizeAuthor
#13 maillog-n2359521-13.patch2.73 KBdamienmckenna
#12 maillog-n2359521-12.patch1.8 KBdamienmckenna
#7 adding_view_link-2359521-7.patch13.12 KBaramboyajyan
#3 maillog-n2359521-after.png23.77 KBdamienmckenna
#3 maillog-n2359521-before.png23.35 KBdamienmckenna
#1 adding_view_link-2359521-1.patch13.13 KBaramboyajyan

Comments

aramboyajyan’s picture

aramboyajyan commented
StatusFileSize
new adding_view_link-2359521-1.patch13.13 KB
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
StatusFileSize
new maillog-n2359521-before.png23.35 KB
new maillog-n2359521-after.png23.77 KB

I uploaded the files as imgur didn't like having the images loaded from the remote hostname.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Note: The view file contains a bunch of extra changes because Views updated its output format, it might be better to manually recreate this.

aramboyajyan’s picture

aramboyajyan commented

Thanks for reviewing, I'll update the view and re-export it shortly.

aramboyajyan’s picture

aramboyajyan commented
Status: Needs work » Needs review
StatusFileSize
new adding_view_link-2359521-7.patch13.12 KB

Updated, please have a look. Thanks!

Status: Needs review » Needs work

The last submitted patch, 7: adding_view_link-2359521-7.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

The patch fails because of #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present .

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Lets do #2655872: Update Views definition first, then this patch will be much simpler to review.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #1238994: Plan for MailLog 7.x-1.0 release

This should be a tiny change that would be worth including in the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new maillog-n2359521-12.patch1.8 KB

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new maillog-n2359521-13.patch2.73 KB

Improved slightly.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.