Why the 0.2em left margin for label in the seven theme?

Same patch. Added the issue number to its file name.

OMG that's a lot to read. ;) Starting with comment #211 in https://www.drupal.org/node/1986418, the screen shots start to show the 0.2em left margin (or right margin for rtl). And perhaps no one else sees the tension between the baseline/descenders and the top of the form field. I've been looking at type for some time now.

Clearly a lot of eyes have been scrutinizing the seven theme, which is great. But let me ask you, don't you think the labels should flush left with their form fields? Is there an intention to the 0.2em left margin?

What caught my eye originally was the label for the body field. The cap B doesn't need to be indented.







In those days, when typesetting was all we did, you wouldn't add an indent for a letter's arm like the cap T in the title label. See the capital letter F in this page from James Felici The Complete Manual of Typography (2003) for terminology.







Indenting the D in database looks wrong to me in these "before" screen shots:

So yes, I think it looks better without the indent, like in your screen shot in #6. Damn the T. :)

Type is subtle. Check this out. Visually the cap D in Database configuration in the next screen shot looks indented when you view it above the capital letter D in Database type. A type "hint" was probably added by the typeface designer to the larger font size. Should we change that now with code? I don't think so. It's very subtle.

You don't want to add more things like an indent for one letter, but not, conceivably for another letter. It's type. It may be inconsistent on a purely technical level, but this inconsistency is accepted as the way things are in type. For instance, why are the cap heights of san-serif typefaces taller than the cap heights of serif typefaces? Perhaps three to five hundred years ago there actually was a technical reason. Now, it's just something that's known about cap heights.

To my practiced eye, the 0.2em left margin looks jarring and we should remove it. I think adding the air between the baseline/descenders and the top border of their form fields is a good idea too.

This is all lingo (cap, cap height, cut space, descender, ascender, arm, air) from the somewhat arcane world of type. I hope I'm not being boring or making it difficult to understand.

Yes, better to just delete the line. There's no need to reset the margin to 0.

Hi. Wow, I was really into this discussion two months ago. That's okay. I do love typography.

Sure, we can stay with margin changes only. I guess I thought padding: 0: on line 28 of form.css seemed unnecessary.

New patch attached.

Indeed yes @idebr. Thanks for your eye.

New patch attached, rolled from root directory this time.

D'oh! #20 was the patch with the padding. We're going with changes to the margins only. Ignore #20, please.

New patch attached.

Well sure, adding space to the bottom of the label is my intent. It alleviates the visual tension between the descenders and the top border of the form field. I'll have a look at #23 and comment again.

Yes, I think we're good to go. Per @idebr comments, there is no reason to keep [dir="rtl"] label {} since the margin we're changing is now identical to label {}. As well as margin: 0 0 0.1em 0 is identical to margin: 0 0 0.1em;. I'm trying to find a views exposed filters form to check if there's anything amiss. But, otherwise, let's commit this. This is a significant change even if the code change is minor.