Hi guys,

I'm trying to use the Commerce Braintree module along side Card on file and Commerce recursion Framework but somehow every time I try to make a purchase (with this method) the order always ends up in pending and is never completed. If i try paying with a different method it always works.

CommentFileSizeAuthor
#2 braintree_paidin_full_2359267-1.patch785 bytespdendis

Comments

czigor’s picture

czigor commented
Title: Not triggering paied in full » Not triggering paid in full

Same issue here. The order status should not be different from Pending but there's no recurring entity created since the commerce_payment_order_paid_in_full rules event does not get fired.

The problem is that in in commerce_payment_order_balance() $transaction->currency_code is not set.

pdendis’s picture

pdendis commented
StatusFileSize
new braintree_paidin_full_2359267-1.patch785 bytes

I attached patch that fix the empty currency code on transaction. Please give a try.

agileadam’s picture

agileadam
Location Maine, USA
commented

I have confirmed that this fixes the issue. Thank you!

TexUs’s picture

TexUs commented

Hi,
I just wanted to chime-in here for future issues...
I'm running latest (as of the date of this post) versions of everything.

I was finding that the payment was "Approved" when you go through Commerce- but couldn't find out why my license downloads and such weren't triggering effectively (and also, why my orders were not going to "Completed" status).
I figured my only hope was, since we are credit-card-only, changing the Rule to trigger based on checkout completion instead of the "paid in full" status (which obviously, wouldn't work if we ever wanted to accept checks, or ship stuff, etc, etc, etc).

I found this patch and it works beautifully out of the box- my licenses are triggering, orders completing, works well. Definitely needs to be integrated to the official build.

nyleve101’s picture

nyleve101 commented

I can confirm this patch also fixed things for me. Thanks!

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
rjdjohnston’s picture

rjdjohnston commented

+1 for commiting

Kiendeleo’s picture

Kiendeleo commented

This worked on the regular version

andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Needs review » Fixed

Not sure how that was missed. Thanks!

  • andyg5000 committed 26a6db1 on 7.x-2.x authored by pdendis 
    Issue #2359267 by pdendis: Not triggering paid in full
Kiendeleo’s picture

Kiendeleo commented

This patch doesn't work for the current dev version. Both the dropin and the standard version still have this bug

Kiendeleo’s picture

Kiendeleo commented
Status: Fixed » Needs work
andyg5000’s picture

andyg5000
Primary language English
Location North Carolina, USA
commented
Status: Needs work » Postponed (maintainer needs more info)

@kiendeleo, is your issue that the order paid in full rules event isn't firing or it just that the order isn't being moved out of the checkout statuses (ie: pending)?

Kiendeleo’s picture

Kiendeleo commented

I am having 2 issues. (correction)

With the 7.x-2.0-beta1 + patch version transactions process but all recurring transactions hard decline.

With 7.x-2.x-dev transactions process but all recurring transactions hard decline.

I am creating a new issue to deal with this as it seems that this is not the same issue.

tomtech’s picture

tomtech commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.