Create a Webform with two components: a page break followed by something else. Set the Webform to save draft when changing pages. When the form is submitted, it will have advanced by two serial numbers.
Why: webform_submission_create() is getting called when the advancing to the next page, but nothing is saved because of the call to return a few lines later ("If there is no data to be saved..."). So, webform_submission_create() is called again on submit. Each time webform_submission_create() is called, the serial number advances.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | webform-2358317-serial_on_save-3.patch | 2.93 KB | danchadwick |
| #1 | webform-2358317-serial_on_save-1.patch | 1.02 KB | liam morland |
| #1 | webform-2358317-save_empty-1.patch | 656 bytes | liam morland |
Comments
Comment #1
liam morlandHere are two possible solutions:
One causes empty submissions to be saved. I don't think the inefficiency is a problem anymore due to changes in webform_get_submissions().
The other assigns the serial number at the same time that the sid is assigned and makes it NULL in webform_submission_create(). I suppose this means that the serial number token would be NULL on a preview page, but maybe that is OK since that token is not certain to be correct anyway.
This might also be fixable in webform_client_form_submit() by having it so that an equivalent to the "If there is no data to be saved..." return statement is called before webform_submission_create().
Comment #2
liam morlandComment #3
danchadwick commentedExcellent. I also remove the $do_update parameter, as it is no longer needed. Yeah!
Committed to 7.x-4.x and 8.x
Comment #5
danchadwick commentedComment #7
danchadwick commented