Closed (fixed)
Project:
File Entity (fieldable files)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Oct 2014 at 15:19 UTC
Updated:
28 Jan 2015 at 18:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tobiasbComment #2
tobiasbComment #3
colanI don't think you need to check for the other two modules as they're already dependencies of Media Bulk Upload.
Comment #4
tobiasbEven better. ;-)
Comment #5
colanLooks good, but is there a use case for uploading multiple files without the Media suite? If there is, we're disallowing it here. Or said another way, if it's possible to upload multiple files with just file_entity, plupload and multiform, this patch won't allow for that anymore; Media will be required.
Comment #6
colanOkay, I see where you're going with this. With only those two modules enabled, you don't get to the edit forms after uploading; the files get saved directly. I agree that it's better to get to the edit forms before saving, but I'm still not sure if it's a good idea to force users to enable the Media suite if they're just interested in File Entity (with multiple file uploads).
Thoughts anyone?
Comment #7
colanSorry, was a little presumptuous there. ;)
Comment #8
tobiasbYou are right. The right place is here http://cgit.drupalcode.org/file_entity/tree/file_entity.pages.inc#n571 ;-)
Comment #9
tobiasbComment #10
brockfanning commented#9 works for me, thanks. In combination with another patch in the media project, I'm able to get bulk/plupload integration with file_entity along with multiform and media_bulk_upload only (no media module). For reference, the other patch is here: https://www.drupal.org/node/2405033 (but it is not required for this patch to work.)
Comment #12
aaron commentedCommitted to http://drupalcode.org/project/file_entity.git/commit/236ec3a.