Media >= 7.x-2.0-alpha4 use a own submodule (media_bulk_upload) to edit multiple files at once. Therefore this module must be enabled.

CommentFileSizeAuthor
#9 fix_menu_callback_for-2356417-9.patch584 bytestobiasb
#4 fix_menu_callback_for-2356417-4.patch513 bytestobiasb
#1 fix_menu_callback_for-2356417-1.patch572 bytestobiasb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
FileSize
fix_menu_callback_for-2356417-1.patch572 bytes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Status: Active » Needs review
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan commented
Status: Needs review » Needs work

I don't think you need to check for the other two modules as they're already dependencies of Media Bulk Upload.

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
fix_menu_callback_for-2356417-4.patch513 bytes

Even better. ;-)

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan commented

Looks good, but is there a use case for uploading multiple files without the Media suite? If there is, we're disallowing it here. Or said another way, if it's possible to upload multiple files with just file_entity, plupload and multiform, this patch won't allow for that anymore; Media will be required.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan commented
Status: Needs review » Reviewed & tested by the community

Okay, I see where you're going with this. With only those two modules enabled, you don't get to the edit forms after uploading; the files get saved directly. I agree that it's better to get to the edit forms before saving, but I'm still not sure if it's a good idea to force users to enable the Media suite if they're just interested in File Entity (with multiple file uploads).

Thoughts anyone?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan commented
Status: Reviewed & tested by the community » Needs review

Sorry, was a little presumptuous there. ;)

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented

You are right. The right place is here http://cgit.drupalcode.org/file_entity/tree/file_entity.pages.inc#n571 ;-)

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
CreditAttribution: tobiasb commented
Issue summary: View changes
FileSize
fix_menu_callback_for-2356417-9.patch584 bytes
brockfanning’s picture

brockfanning CreditAttribution: brockfanning commented
Status: Needs review » Reviewed & tested by the community

#9 works for me, thanks. In combination with another patch in the media project, I'm able to get bulk/plupload integration with file_entity along with multiform and media_bulk_upload only (no media module). For reference, the other patch is here: https://www.drupal.org/node/2405033 (but it is not required for this patch to work.)

  • aaron committed 236ec3a on 7.x-2.x 
    Issue #2356417 by tobiasb: fixed Fix menu callback for multiple file...
aaron’s picture

aaron CreditAttribution: aaron commented
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/file_entity.git/commit/236ec3a.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.