Problem/Motivation

RelationLinkManager::getRelationInternalIds references RelationLinkManagerInterface::getRelationInternalIds but there is no such method

Proposed resolution

Add it

Remaining tasks

Review

User interface changes

None

API changes

Interface method that should have been there, is there.

Patch coming

CommentFileSizeAuthor
#10 rest-link-mgrs-2355977.10.patch3.44 KBlarowlan
#9 rest-link-mgrs-2355977.9.patch1.95 MBlarowlan
#9 interdiff.txt3.28 KBlarowlan
#6 est-relation-link-manager-interface-2355977.6.patch3.89 KBdashaforbes
#6 interdiff.txt652 bytesdashaforbes
#3 rest-interfi-2355977.2.patch3.89 KBlarowlan
#3 interdiff.txt626 byteslarowlan
#1 rest-interfi-2355977.1.patch3.28 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new rest-interfi-2355977.1.patch3.28 KB

winner winner chicken dinner

Status: Needs review » Needs work

The last submitted patch, 1: rest-interfi-2355977.1.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt626 bytes
new rest-interfi-2355977.2.patch3.89 KB
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/rest/src/LinkManager/RelationLinkManagerInterface.php
@@ -23,4 +23,31 @@
    */
   public function getRelationUri($entity_type, $bundle, $field_name);
...
+   * @return array
+   *   Array with keys 'field_name', 'entity_type' and 'bundle'.
+   */
+  public function getRelationInternalIds($relation_uri);

Should we order the documentation in the way it makes sense? entity_type, bundle and then field_name.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Novice

sure

dashaforbes’s picture

dashaforbes commented
StatusFileSize
new interdiff.txt652 bytes
new est-relation-link-manager-interface-2355977.6.patch3.89 KB

this is my first drupal core patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +needs test 
+++ b/core/modules/rest/src/LinkManager/LinkManager.php
@@ -62,4 +62,12 @@ public function getRelationUri($entity_type, $bundle, $field_name) {
+  /**
+   * {@inheritdoc}
+   */
+  public function getRelations() {
+    return $this->relationLinkManager->getRelations();
+  }

This function must be untested and unused...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.28 KB
new rest-link-mgrs-2355977.9.patch1.95 MB

RelationLinkManager::getRelations and TypeLinkManager::getTypes are both public but the only uses in core are by themself - moved them to protected and removed the extra function/from the interface

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: -Novice, -needs test
StatusFileSize
new rest-link-mgrs-2355977.10.patch3.44 KB

whoops, didn't merge 8.0.x

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

I think the patch in #10 addresses the concerns raised above.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 7c0295d and pushed to 8.0.x. Thanks!

  • alexpott committed 7c0295d on 8.0.x 
    Issue #2355977 by larowlan, dashaforbes: Fixed Code references...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.