Closed (fixed)
Project:
Panels
Version:
6.x-3.x-dev
Component:
Plugins - content types
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2014 at 23:32 UTC
Updated:
10 Dec 2015 at 09:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damienmckennaComment #3
damienmckennaRerolled with the proper path.
Comment #4
rjay commentedThe patch in #3 fixes the warning on line 243 of panels_renderer_legacy.class.php when attempting to add a CSS class when there is no content for a pane. The same warning can also happen on line 238 when trying to add a CSS id when there is no content. This patch fixes both warnings.
Comment #5
michelleCould you provide steps to reproduce? Based on #4, I tried adding a pane via "new custom content" and didn't give it any content. I also tried adding a view pane that I knew returned no results nor empty text. Neither of them had errors either while I was adding the ID/class nor saving the page nor displaying the page. I'd be happy to try testing again if someone could provide the steps.
Comment #6
rjay commented@Michelle: When you were testing did you confirm that there was a plugin that was forcing Panels to use the legacy renderer? Panels displays a message about this on the Status Report page for me. Also make sure you are running PHP >= 5.4 (this issue occured on PHP 5.6 for me).
In my case the issue occured with a pane that contained a view, which was returning no results and had no empty text (which was one of your test cases as well). The warning appeared for me when viewing the page, not while adding/editing the pane. I was using Views 6.x-2.x, though I'm not sure if that makes a difference.
Comment #7
michelleI don't know how to get "a plugin that was forcing Panels to use the legacy renderer" so that was likely why I wasn't able to repro it.
Comment #8
japerryWorks. fixed.