Problem/Motivation
We do have a generic automatic views integration for entities, let's use it to safe some code.
Proposed resolution
Let AggregatorItemViewsData and AggregatorFeedViewsData extend EntityViewsData but ensure that the special integration is still in there.
Have a look at NodeViewsData for inspiration.
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | use-entityviewsdata-2355239-7.patch | 10.99 KB | kgoel |
| #5 | use-entityviewsdata-2355239-5.patch | 11 KB | kgoel |
| #3 | use-entityviewsdata-2355239-3.patch | 11 KB | kgoel |
| #1 | use-entityviewsdata-2355239-1.patch | 11.01 KB | kgoel |
Comments
Comment #1
kgoel commentedComment #3
kgoel commentedComment #5
kgoel commentedFixed typo
Comment #7
kgoel commentedFixed two silly mistake.
Comment #8
dawehnerIts a great cleanup and reduction of the file size. Great work!
Feel free to also post the interdiffs over time.
Comment #9
alexpottCommitted 45e51b0 and pushed to 8.0.x. Thanks!
On commit I changed all
t()to$this->t()here too - since we were touching every line.