Comments

ashutoshsngh’s picture

Status: Needs work » Needs review
StatusFileSize
new845 bytes
claudiu.cristea’s picture

Issue tags: -Novice. @deprecated +Novice, +@depreacted

Please merge #2354999: Remove usage of form_builder(). here. They are the same issue.

claudiu.cristea’s picture

Status: Needs review » Needs work
ashutoshsngh’s picture

Status: Needs work » Needs review
StatusFileSize
new7.36 KB

Done as mentioned in #2.

claudiu.cristea’s picture

Status: Needs review » Needs work
+++ b/core/includes/common.inc
@@ -2541,7 +2541,7 @@ function drupal_prepare_page($page) {
+ *     drupal_render(), such as \Drupal::formBuilder()->doBuildForm() in the Form API.

+++ b/core/includes/form.inc
@@ -520,7 +508,7 @@ function template_preprocess_form_element(&$variables) {
+  // may not necessarily have been processed by \Drupal::formBuilder()->doBuildForm().

+++ b/core/lib/Drupal/Core/Form/FormState.php
@@ -1147,7 +1147,7 @@ public function cleanValues() {
+    // \Drupal::formBuilder()->doBuildForm() collects all button elements in a form. We remove the button

+++ b/core/modules/file/file.module
@@ -1493,7 +1493,7 @@ function template_preprocess_file_managed_file(&$variables) {
+ * on the managed_file element's #value. See the documentation of \Drupal::formBuilder()->doBuildForm()

+++ b/core/modules/filter/src/Element/TextFormat.php
@@ -76,11 +76,11 @@ public static function processFormat(&$element, FormStateInterface $form_state,
+      // Do not copy this #process function to prevent \Drupal::formBuilder()->doBuildForm() from

+++ b/core/modules/system/src/Tests/Common/RenderWebTest.php
@@ -26,7 +26,7 @@ class RenderWebTest extends WebTestBase {
+   * Tests rendering form elements without passing through \Drupal::formBuilder()->doBuildForm().

+++ b/core/modules/views_ui/admin.inc
@@ -137,7 +137,7 @@ function views_ui_add_limited_validation($element, FormStateInterface $form_stat
+  // was clicked, the form API workflow in \Drupal::formBuilder()->doBuildForm() will have already

+++ b/core/modules/views_ui/src/ViewEditForm.php
@@ -1156,7 +1156,7 @@ public function getFormBucket(ViewUI $view, $type, $display) {
+   * Recursively adds microweights to a render array, similar to what \Drupal::formBuilder()->doBuildForm() does for forms.

Doc block lines should be wrapped at 80 characters and rearranged accordingly.

pushpinderchauhan’s picture

Status: Needs work » Needs review
StatusFileSize
new7.79 KB

Done.

Doc block lines should be wrapped at 80 characters and rearranged accordingly.
claudiu.cristea’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

claudiu.cristea’s picture

Status: Reviewed & tested by the community » Needs work

Another small catch...

+++ b/core/modules/views_ui/admin.inc
@@ -137,7 +137,7 @@ function views_ui_add_limited_validation($element, FormStateInterface $form_stat
+  // was clicked, the form API workflow in \Drupal::formBuilder()->doBuildForm() will have already

This need wrap and rearrange.

Please post, also, every time an interdiff. Without that it's hard to track relative changes.

dinarcon’s picture

Status: Needs work » Needs review
StatusFileSize
new8.39 KB
new1.35 KB

A new patch with the change suggested by @claudiu.cristea in #8.

claudiu.cristea’s picture

Status: Needs review » Reviewed & tested by the community

Good to go.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed e8d6588 on 8.0.x
    Issue #2355001 by ashutoshsngh, dinarcon, er.pushpinderrana: Remove form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mile23’s picture

Issue tags: -@depreacted +@deprecated