uuid_create function shipped with the uuid pecl extension uses pass-by-reference.
In ctools this function is used as a first alternative in ctools_uuid_generate for uuid generation. But in the module a constant is passed as argument which cause fatal error for php version > 5.3
For more information check the links below:
http://php.net/manual/en/language.references.pass.php
https://bugs.php.net/bug.php?id=58891

CommentFileSizeAuthor
#1 uuid_create_function-2354877-1.patch427 bytesboyan.borisov

Comments

boyan.borisov’s picture

boyan.borisov commented
Status: Active » Needs review
StatusFileSize
new uuid_create_function-2354877-1.patch427 bytes

I created a quick fix which solved the issue.

jweowu’s picture

jweowu commented
Status: Needs review » Reviewed & tested by the community

+1

Not marking RTBC as I've not actually tested it; but the code change is trivial and looks correct.

jweowu’s picture

jweowu commented
Status: Reviewed & tested by the community » Needs review

D'oh :)

jweowu’s picture

jweowu commented
Related issues: +#2349237: Fatal error: Only variables can be passed by reference in /var/www/html/drupal-7.29/sites/all/modules/uuid/uuid.inc on line 164

Linking to equivalent issue for the UUID module. We appropriate code from the UUID module, so we should treat the UUID issue as the parent, and port back any fixes to keep the code synchronised.

DamienMcKenna queued 1: uuid_create_function-2354877-1.patch for re-testing.

willyk’s picture

willyk commented

I tested the patch posted by DamienMcKenna in #5 and it resolved the issue.

jweowu’s picture

jweowu commented
Status: Needs review » Reviewed & tested by the community

Marking RTBC on account of having previously reviewed the code change, combined with willyk's test/verification.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Yup, simple change. Done.

  • japerry committed dbf1cff on 7.x-1.x authored by boyan.borisov 
    Issue #2354877 by boyan.borisov: uuid_create function cause fatal error...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.