Comments

oadaeh’s picture

Status: Active » Needs work
Issue tags: +Needs tests
StatusFileSize
new1.11 KB

Attached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.

miguelc303’s picture

Added organization support to Anexus IT

jcost’s picture

Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new2.65 KB

Updated and wrote a test.

quietone’s picture

StatusFileSize
new2.51 KB
new4.46 KB

reroll

quietone’s picture

Oh, and moved to the user module

mikeryan’s picture

Status: Needs review » Needs work
StatusFileSize
new6.79 KB

Attached are the diffs from the D6 version (always very useful in reviewing D7 migrations where the D6 and D7 source didn't change much).

  1. +++ b/core/modules/user/migration_templates/d7_user_settings.yml
    @@ -0,0 +1,32 @@
    +dependencies:
    +  module:
    +    - migrate_drupal
    +    - user
    

    Explicit dependencies are not needed.

  2. +++ b/core/modules/user/src/Tests/Migrate/d7/MigrateUserSettingsTest.php
    @@ -0,0 +1,44 @@
    + * Contains \Drupal\migrate_drupal\Tests\d7\MigrateUserSettingsTest.
    

    s/migrate_drupal/user/

  3. +++ b/core/modules/user/src/Tests/Migrate/d7/MigrateUserSettingsTest.php
    @@ -0,0 +1,44 @@
    +use Drupal\migrate\MigrateExecutable;
    +use Drupal\migrate_drupal\Entity\Migration;
    

    These use statements are unused (grey in PhpStorm).

  4. +++ b/core/modules/user/src/Tests/Migrate/d7/MigrateUserSettingsTest.php
    @@ -0,0 +1,44 @@
    +class MigrateUserSettingsTest extends MigrateDrupal7TestBase {
    

    D6 version is MigrateUserConfigsTest

  5. +++ b/core/modules/user/src/Tests/Migrate/d7/MigrateUserSettingsTest.php
    @@ -0,0 +1,44 @@
    +  public function testMigration() {
    

    D6 version was named testUserSettings().

    testUserMail() from D6 is not present at all here. I don't think much if anything changed in this area between D6 and D7?

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new12.96 KB
new13.13 KB

1. fixed
2. fixed
3. fixed
4. D6 and D7 class names are the same
5. method name changed to match D6 version of test

Using the interdiff led me to find a few things. thx mikeryan
1, Add user_mail_status_deleted_notify to the D6 test, and the equivalent user_mail_status_canceled_notify to the D7 test.
2. Remove the duplicate 'user_mail-' from the following names in the D6 side of things
- user_mail_user_mail_register_pending_approval_subject
- user_mail_user_mail_register_pending_approval_body

Status: Needs review » Needs work

The last submitted patch, 9: 2353817-9.patch, failed testing.

quietone’s picture

Status: Needs work » Needs review
StatusFileSize
new2.43 KB
new14.91 KB

The name changes in Variable.php got missed in that patch. Here they are.

quietone’s picture

phenaproxima’s picture

Status: Needs review » Closed (won't fix)

The migration in #11 has been rolled into #2414651: Migration Files for Drupal 7 Users, so we can close this one out.