update_variables_to_config('locale.settings', array(
    'locale_cache_strings' => 'cache_strings',
    'locale_js_directory' => 'javascript.directory',
  ));

See parent issue #2181257: [meta] Variables to config migration [d7] for instructions.

CommentFileSizeAuthor
#15 interdiff-2353761-13-15.txt429 bytesphenaproxima
#15 2353761-15.patch2.38 KBphenaproxima
#13 interdiff-2353761-11-13.txt3.46 KBphenaproxima
#13 2353761-13.patch1.82 KBphenaproxima
#11 2353761-11.patch2.83 KBquietone
#10 2353761-10.patch2.83 KBphenaproxima
#8 2353761-8.patch11.11 KBphenaproxima
#7 2353761-7.patch3.01 KBphenaproxima
#6 2353761-6.patch906 bytesphenaproxima
#1 locale_settings-2353761-1.patch701 bytesoadaeh

Comments

oadaeh’s picture

oadaeh commented
Issue tags: +Needs tests
StatusFileSize
new locale_settings-2353761-1.patch701 bytes

Attached is the YAML for this issue, from the patch in #2382117: Migration Files for Drupal 7 Variables.
Test(s) (and maybe a dump file) still need to be written.

oadaeh’s picture

oadaeh commented
Status: Active » Needs work
miguelc303’s picture

miguelc303 commented

Added organization support to Anexus IT

jcost’s picture

jcost commented
Project: IMP » Drupal core
Version: » 8.0.x-dev
Component: Code » migration system

Will need to be submitted again to Core since moving from sandbox.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Parent issue: #2181257: [meta] Variables to config migration [d7] » #2500501: Upgrade path for Locale 7.x
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2353761-6.patch906 bytes

Updated for HEAD and wrote a test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353761-7.patch3.01 KB

Um...might be nice to include an actual test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353761-8.patch11.11 KB

Re-rolled in accordance with #2533886: [meta] Move module-specific migration support into the particular modules supported.

Status: Needs review » Needs work

The last submitted patch, 8: 2353761-8.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353761-10.patch2.83 KB

Whoops, screwed up the re-roll in #8. This one should work. Can't include an interdiff due to conflicts in the Variable.php table dump.

quietone’s picture

quietone commented
StatusFileSize
new 2353761-11.patch2.83 KB

reroll
As phenaproxima said, no interdiff because of conflicts in Variable.php

quietone’s picture

quietone commented

And moved the migration to the locale module

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2353761-13.patch1.82 KB
new interdiff-2353761-11-13.txt3.46 KB

While reviewing this, I noticed that d6_locale_settings and d7_locale_settings are identical. So I merged them into a single migration, tagged for both Drupal 6 and Drupal 7, and using the existing Drupal 6 test as the test for both.

Status: Needs review » Needs work

The last submitted patch, 13: 2353761-13.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 2353761-15.patch2.38 KB
new interdiff-2353761-13-15.txt429 bytes

Whoops. I'm really starting to dislike that laundry list of migration IDs in MigrateDrupal6Test.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

reuse++

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice! Love the consolidation here. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 125844e on 8.0.x 
    Issue #2353761 by phenaproxima, oadaeh, quietone: Variable to config:...

The last submitted patch, 1: locale_settings-2353761-1.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.