Problem/Motivation

The feed_item_length variable does not have a migration to D8 (system.rss).

Proposed resolution

Create the migration.

Remaining tasks

Create the migration, write the test.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#2 2353695-2.patch1.74 KBultimike
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Parent issue: » #2353665: [meta] Variables to config migration [d6]
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Status: Active » Needs review
FileSize
2353695-2.patch1.74 KB

Patch attached.

Thanks,
-mike

benjy’s picture

benjy CreditAttribution: benjy commented

Looks good to me.

+++ b/core/modules/migrate_drupal/config/install/migrate.migration.d6_system_rss.yml
@@ -6,8 +6,10 @@ source:
+  'items/view_mode': feed_item_length

Is the key really view_mode for what used to be feed_item_length?

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented

Benjy,

Yep, that threw minute for a few minutes, but that's what it is called in D8. See http://note.io/1ogI9o6

Thanks,
-mike

benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs review » Reviewed & tested by the community

OK, I checked this in D6 as well and this patch is right. RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 1b06ce8 and pushed to 8.0.x. Thanks!

  • alexpott committed 1b06ce8 on 8.0.x 
    Issue #2353695 by ultimike: D6->D8 Migration missing variable:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.