Problem/Motivation

The forum_nav_vocabulary variable does not have a migration to D8 (forum.settings).

It looks like this was considered at some point, because there is some commented out code in the MigrateForumConfigsTest.

Proposed resolution

Create the migration.

Remaining tasks

Create the migration, write the test.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#6 2353667-6.patch2.47 KBmicnap
#5 2353667-5.patch2.5 KBmicnap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Issue summary: View changes
micnap’s picture

micnap CreditAttribution: micnap commented
Assigned: Unassigned » micnap
micnap’s picture

micnap CreditAttribution: micnap commented

Mike,
Not sure how to handle this one. forum_nav_vocabulary sets the vid of the vocabulary to use for the forum vocabulary. That's likely going to be different between d6 and d8. I'm guessing code will have to be written to check the vocabulary name? Or what would be the best way to handle this?

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented

Hmm - I'm thinking we could make this migration dependent on the d6_taxonomy_vocabulary migration (so vocabularies are migrated first), then use the migration plugin...

-mike

micnap’s picture

micnap CreditAttribution: micnap commented
FileSize
2353667-5.patch2.5 KB

Patch attached.

micnap’s picture

micnap CreditAttribution: micnap commented
FileSize
2353667-6.patch2.47 KB

Second attempt.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
CreditAttribution: ultimike commented
Status: Active » Needs review
benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs review » Reviewed & tested by the community

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f4b4adf and pushed to 8.0.x. Thanks!

  • alexpott committed f4b4adf on 8.0.x 
    Issue #2353667 by micnap | ultimike: D6->D8 Migration missing variable:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.