I have noticed that the autocomplete suggestions popup is randomly displaying incorrectly.

In linkit/better-autocomplete/jquery.better-autocomplete.js
If I comment out line 921 and 922:

left: $input.position().left,
        top: $input.position().top + $input.outerHeight(),

Everything seems to work correctly.

I using Google Chrome 38 on a Mac.

Let me know if you want a patch for this.

CommentFileSizeAuthor
#4 linkit-fix-autocomplete-styling-2353105-4.patch1.11 KBgmclelland
#3 linkit-fix-autocomplete-styling-2353105.patch635 bytesgmclelland
linkit.jpg56.02 KBgmclelland

Comments

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Active » Needs review

I have also noticed that this bug is not always there, sometimes it exists on new nodes, and sometimes on old once.

Anyway, thanks for the patch, I will try this and hope this solves it for all situations.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

And yes, a patch file would be nice.

gmclelland’s picture

gmclelland commented
StatusFileSize
new linkit-fix-autocomplete-styling-2353105.patch635 bytes

Here's a patch. In the meantime, I'll keep testing this patch to see if it fixes the problem.

Thanks for making the linkit module. Drupal wouldn't be the same without it.

gmclelland’s picture

gmclelland commented
StatusFileSize
new linkit-fix-autocomplete-styling-2353105-4.patch1.11 KB

Looks like I missed another place. Here is a new patch. I will keep testing, but I think this should fix the problem. Hope that helps

sylus’s picture

sylus commented
Status: Needs review » Reviewed & tested by the community

I have been running into this problem as well but haven't seen it occur anymore since applying the latest patch. Thanks a bunch!

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Reviewed & tested by the community » Fixed

Thanks for patch.

  • anon committed a81f614 on 7.x-3.x authored by gmclelland 
    Issue #2353105 by gmclelland: Autocomplete popup styling is off

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 3: linkit-fix-autocomplete-styling-2353105.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 4: linkit-fix-autocomplete-styling-2353105-4.patch, failed testing.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs work » Closed (fixed)

Closing again, the test bot change the status for some reason.