From the linked issue:

"On my two installations, only views that had overridden the default Metatag setting are showing the Meta Tags section. Pre-existing views with no custom meta tags set, or newly created page views, do not show the Meta Tags options. This appears to be the case for sites using both the patch in #1 and the patch in #14."

CommentFileSizeAuthor
#5 metatag-n2353079-5.patch4.7 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Parent issue: » #2352445: META: Plan for Metatag 7.x-1.4 release

Sorry. :-(

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

I've confirmed the problem. Dangit :(

mloveridge17’s picture

mloveridge17 CreditAttribution: mloveridge17 commented

Does 'confirming' the problem mean that your first comment, #1 is null and that this is a bug to be fixed in 7x-1.4?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Version: 7.x-1.3 » 7.x-1.x-dev

I've confirmed the bug exists, and that I want to fix it for the next release. I've not found a solution, neither has anyone else posted a working patch therefore I can't say when a fix will be available.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
FileSize
metatag-n2353079-5.patch4.7 KB

I believe this should work.

The problem stemmed from logic changes in options_summary() that were incorrect.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
pkiff’s picture

pkiff CreditAttribution: pkiff commented

I'm the one whose post is quoted in the issue description. I have tested the same two installations with this newest patch, applied to metatag 7.x-1.3. This patch appears to resolve the issue in the two cases I am working with.

I have not reviewed any of the code, but just checked to see that the Meta Tags section appears correctly in the Views UI, regardless of whether that view is using default or overridden values. All looks good to me.

Thanks for continuing to work on this today, Damien. Metatags is a very helpful module, and I find it especially valuable for producing properly tagged Views pages.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

@pkiff: Thanks for the review, hopefully we'll have some others take a look too.

ofry’s picture

ofry CreditAttribution: ofry commented
Status: Needs review » Reviewed & tested by the community

Patch #5 working fine! This problem has solved!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Reviewed & tested by the community » Fixed

Thanks for the reviews. I've committed the patch.

  • DamienMcKenna committed 7da3938 on 7.x-1.x 
    Issue #2353079 by DamienMcKenna: Fixed Views integration, for real this...
mloveridge17’s picture

mloveridge17 CreditAttribution: mloveridge17 commented

I'm slower than all y'all at implementing the fixes, but I finally got it in place and it looks to be working as expected.

@DamienMcKenna Thank you so much for all of your efforts on this module. It is greatly appreciated!

lquessenberry’s picture

lquessenberry CreditAttribution: lquessenberry commented

Worked for me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.