Follow-up to #2285413: [Meta] Standardize entity route names

Problem/Motivation

Original meta issue needs this follow-up to clean-up more routes

Proposed resolution

Extract changes from #2281645: Make entity annotations use link templates instead of route names

Remaining tasks

file a patch

User interface changes

None.

API changes

field_ui routes will have different names.

CommentFileSizeAuthor
#6 2352385-book-forum-routes-6.patch7.53 KBandypost
#3 2352385-book-forum-routes-3.patch7.67 KBandypost
#3 interdiff.txt2.92 KBandypost
#1 2352385-1.patch6.61 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
2352385-1.patch6.61 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Glad you are back, hopefully well.

+++ b/core/modules/forum/src/Form/ForumForm.php
@@ -80,7 +80,7 @@ public function save(array $form, FormStateInterface $form_state) {
-    $route_name = $this->urlStub == 'container' ? 'forum.edit_container' : 'forum.edit_forum';
+    $route_name = $this->urlStub == 'container' ? 'forum.edit_container' : 'entity.taxonomy_term.forum_edit_form';

As done in the other issue by myself already, let's use entity.taxonomy_term.forum_edit_container as well.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt2.92 KB
2352385-book-forum-routes-3.patch7.67 KB

Thanx, fixed #2

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

This looks good now

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 2352385-book-forum-routes-3.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Reviewed & tested by the community
FileSize
2352385-book-forum-routes-6.patch7.53 KB

re-roll after #2347465: Convert all instances of #type link/links to convert to use routes

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed c8f9c9b and pushed to 8.0.x. Thanks!

  • alexpott committed c8f9c9b on 8.0.x 
    Issue #2352385 by andypost: Standardize book & forum entity route names.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.