Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
responsive_image.module
Priority:
Major
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
3 Oct 2014 at 13:55 UTC
Updated:
11 Dec 2014 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
attiks commentedComment #2
rvolkCheck this patch with a non-image-style fallback solution.
The default file_create_url function will be used, if the image_style entity is not available.
There is as well a following error fixed in the patch:
Comment #3
mgoedecke commentedpatch solves both problems
Comment #4
aspilicious commentedPut both on 1 line and don't use 'and' we *never* do that in core.
Comment #5
rvolkHere we go... thanks for the advice.
Comment #6
luksakWork for me. RTBC i guess...
Comment #7
webchickLooks like this needs an automated test.
Comment #8
naxoc commentedComment #9
naxoc commentedHere is a test that should catch that.
I'm not sure how many ways responsive image mappings can be created but I think we should make the image style field required on the form?
Also, no interdiff - I only touched the test.
Comment #11
attiks commentedTest looks good, back to RTBC
Comment #12
alexpottSo no one seems to have answered the question - should we be able to create mappings without an image style. Looking at the code it seems so since
passing in
TRUEmeans we get a none option.Whilst reviewing the code I've realised that ResponsiveImageMappings are missing a dependency on the ImageStyle config entities - created #2383165: ResponsiveImageStyle config entities should depend on the image styles they use
This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 82584e6 and pushed to 8.0.x. Thanks!