(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/rdf/templates/rdf-metadata.html.twig

Files: 
CommentFileSizeAuthor
#10 interdiff.txt1.15 KBXen
#10 copy_rdf_templates_to-2349727-10.patch707 bytesXen
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,651 pass(es). View
#4 copy_rdf_templates_to-2349727-4.patch1.35 KBcilefen
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,643 pass(es). View
#4 interdiff-2-4.txt1.58 KBcilefen
#2 copy_rdf_templates_to-2349727-2.patch1.36 KBcilefen
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,923 pass(es). View

Comments

cilefen’s picture

Assigned: Unassigned » cilefen
cilefen’s picture

Assigned: cilefen » Unassigned
Status: Active » Needs review
Issue tags: +Novice
FileSize
1.36 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,923 pass(es). View
davidhernandez’s picture

Status: Needs review » Needs work

The template should go directly into the templates folder, not a subfolder.

cilefen’s picture

Status: Needs work » Needs review
FileSize
1.58 KB
1.35 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,643 pass(es). View
mortendk’s picture

Issue tags: +drupalhagen
Xen’s picture

Assigned: Unassigned » Xen
Xen’s picture

Assigned: Xen » Unassigned
Status: Needs review » Reviewed & tested by the community

Works. Is used when using Bartik.

alexpott’s picture

+++ b/core/modules/rdf/templates/rdf-metadata.html.twig
@@ -18,5 +18,5 @@
-  <span{{ attributes.addClass('rdf-meta', 'hidden') }}></span>
+  <span{{ attributes }}></span>

Are we sure that removing the hidden class is desirable here?

Xen’s picture

Assigned: Unassigned » Xen

No, you're right. I'll reroll.

Xen’s picture

FileSize
707 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,651 pass(es). View
1.15 KB

There...

Xen’s picture

Assigned: Xen » Unassigned
mortendk’s picture

Issue tags: +cssbanana
davidhernandez’s picture

Status: Reviewed & tested by the community » Needs review

I'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

mortendk’s picture

Status: Needs review » Reviewed & tested by the community

no js affected

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

The class rdf-meta is not used anywhere.

Committed b913cea and pushed to 8.0.x. Thanks!

This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?

  • alexpott committed b913cea on 8.0.x
    Issue #2349727 by cilefen, Xen | davidhernandez: Copy rdf templates to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.