CommentViewBuilder should use static where possible, subclassing is currently too painful

Two of these will fail, can't use static in string callback

It's a little shortsighted of #post_render_cache to key by the $callback, since normally we'd use an array for this. Trying concatenating instead.

Ahh, drupal_render_cache_generate_placeholder does not support callables either, only strings.

1. +++ b/core/modules/comment/src/CommentViewBuilder.php
   @@ -197,7 +197,7 @@ public function buildComponents(array &$build, array $entities, array $displays,
   +    $callback = get_class() . '::renderLinks';
   

   Lets just move this to the service (CommentPostRenderCache) where we can have real DI an no \Drupal and then it can be swapped/subclassed easily

2. +++ b/core/modules/comment/src/CommentViewBuilder.php
   @@ -209,8 +209,7 @@ public static function renderLinks(array $element, array $context) {
   +      $links['comment'] = static::buildLinks($entity, $commented_entity);
   

   +1

8.1 can be followup

#2350273: Move CommentViewBuilder::renderLinks post_render_cache callback to CommentPostRenderCache

Committed bc20bd5 and pushed to 8.0.x. Thanks!

Don't we really want get_called_class() here instead of get_class()?

Um, yeah we do. Either get_called_class() or get_class($this)

Yeah, see http://3v4l.org/E6Cjk

/me didn't even know of that function - thanks

Cool

trivial patch of the month?

Committed 6d5e445 and pushed to 8.0.x. Thanks!