[META-0 theme functions left] Convert/refactor core theme functions [#2348381]

Problem/Motivation

We want to remove all theme functions from core by RC1.

Proposed resolution

Convert/refactor the remaining theme functions in the sub-issues.

Remaining child/grandchild issues (higher priority issues at the top)

Theme function name	Issue/next steps
theme_field_ui_table	#1938900: Convert theme_field_ui_table into a template
theme_language_content_settings_table	#1938912: Convert language content setting table theme to a twig template

Completed

Theme function name	Completed Issue
theme_system_modules_uninstall	#2151113: Convert theme_system_modules_uninstall() to Twig
theme_system_modules_details	#2151109: Convert theme_system_modules_details() to Twig
theme_authorize_message	#1885564: theme.maintenance.inc (authorize.php) - Convert theme_ functions to Twig
theme_authorize_report
theme_views_ui_build_group_filter_form	#1963978: Convert theme_views_ui_build_group_filter_form() to Twig
theme_book_link	#2443361: Remove theme_book_link, make book tree align with MenuLinkTree build
theme_responsive_image_formatter	#1898442: responsive_image.module - Convert theme_ functions to Twig
theme_book_admin_table	#1968982: Convert book theme tables to table #type
theme_locale_translate_edit_form_strings	#1938916: Convert locale theme tables to table #type
theme_menu_overview_form	#1938918: Convert menu theme tables to table #type Assigned to: botanic_spark
theme_node_search_admin	#1938920: Convert node_search_admin theme tables to table #type
theme_system_compact_link	#1833932: Convert theme_system_compact_link() into a #type link
theme_views_view_fields	#2348747: Convert theme_views_view_fields() to 100% Twig: remove the theme function
theme_views_view_field	#2348729: Convert theme_views_view_field to twig
theme_indentation	#2578567: Remove theme_indentation() and use Twig template only
theme_language_negotiation_configure_browser_form_table	#2422481: Convert language negotiation theme table to table #type

The total count of remaining (not including test functions) theme functions in core is displayed in the issue title. The following search can be run in ack 2.x to get the current number:

ack 'function theme_[^(]+\([^$]*(\$variables)*\) ?{' --ignore-dir=core/modules/system/tests core | wc -l

Remove the | wc -l to get a list of the remaining theme functions.

User interface changes

n/a

API changes

Theme functions will be removed.

Comments

Comment #1

star-szr

he/him

English

commented 1 October 2014 at 17:07

Issue summary:

View changes

Comment #2

manuel garcia commented 2 October 2014 at 09:10

Issue summary:

View changes

Added #2348729: Convert theme_views_view_field to twig

Comment #3

manuel garcia commented 2 October 2014 at 09:41

Issue summary:

View changes

Added #2348747: Convert theme_views_view_fields() to 100% Twig: remove the theme function

Comment #4

star-szr

he/him

English

commented 3 October 2014 at 00:29

Issue summary:

View changes

Moving the ack search over from #1757550: [Meta] Convert core theme functions to Twig templates.

Comment #5

joelpittet

he/him

English

Vancouver

commented 3 October 2014 at 10:13

Issue summary:

View changes

Comment #6

joelpittet

he/him

English

Vancouver

commented 2 December 2014 at 19:39

Title:	[META-20 theme functions left] Convert/refactor core theme functions	» [META-17 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Splitting off the complete issues. 3 more down;) 17 to go!

Comment #7

star-szr

he/him

English

commented 3 February 2015 at 01:15

Title:	[META-17 theme functions left] Convert/refactor core theme functions	» [META-16 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Bye theme_book_admin_table()! #1968982: Convert book theme tables to table #type

Comment #8

star-szr

he/him

English

commented 3 February 2015 at 01:17

Issue summary:

View changes

Comment #9

star-szr

he/him

English

commented 3 February 2015 at 01:19

Issue summary:

View changes

Comment #10

star-szr

he/him

English

commented 3 February 2015 at 02:04

Title:	[META-16 theme functions left] Convert/refactor core theme functions	» [META-15 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Hmm, somehow we have an off by one error in the ack command. Time for trusty ol' wc -l :)

Comment #11

star-szr

he/him

English

commented 11 February 2015 at 18:18

Title:	[META-15 theme functions left] Convert/refactor core theme functions	» [META-13 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Thank you #2260061: Responsive image module does not support sizes/picture polyfill 2.2! Just one theme function left now in responsive_image.module.

Comment #12

manuel garcia commented 28 February 2015 at 15:27

Issue summary:

View changes

Comment #13

star-szr

he/him

English

commented 12 March 2015 at 23:45

Issue summary:

View changes

Separating out the higher priority issues from the things we can live with being theme functions in 8.0.0 :)

Comment #14

star-szr

he/him

English

commented 12 March 2015 at 23:48

Issue summary:

View changes

Swapping theme_views_view_fields() and theme_views_view_field().

Comment #15

star-szr

he/him

English

commented 27 April 2015 at 16:03

Title:	[META-13 theme functions left] Convert/refactor core theme functions	» [META-12 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Thank you #2123251: Improve DX of responsive images; convert theme functions to new #type element! One more down :D

Comment #16

star-szr

he/him

English

commented 9 June 2015 at 10:27

Title:

[META-12 theme functions left] Convert/refactor core theme functions

» [META-11 theme functions left] Convert/refactor core theme functions

#2443361: Remove theme_book_link, make book tree align with MenuLinkTree build is in! Maybe we can get to single digits by RC1.

Comment #17

star-szr

he/him

English

commented 9 June 2015 at 10:28

Issue summary:

View changes

Moving down to completed.

Comment #18

star-szr

he/him

English

commented 13 July 2015 at 16:57

Title:	[META-11 theme functions left] Convert/refactor core theme functions	» [META-10 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Another down: #1963978: Convert theme_views_ui_build_group_filter_form() to Twig

Comment #19

joelpittet

he/him

English

Vancouver

commented 11 August 2015 at 22:57

Title:	[META-10 theme functions left] Convert/refactor core theme functions	» [META-8 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

#1885564: theme.maintenance.inc (authorize.php) - Convert theme_ functions to Twig committed! Booyah

Comment #20

joelpittet

he/him

English

Vancouver

commented 11 August 2015 at 22:57

Issue summary:

View changes

Comment #21

joelpittet

he/him

English

Vancouver

commented 11 August 2015 at 22:58

Issue summary:

View changes

Comment #22

akalata commented 24 September 2015 at 10:15

Issue summary:

View changes

Comment #23

akalata commented 25 September 2015 at 09:36

Issue summary:

View changes

Comment #24

akalata commented 25 September 2015 at 12:19

Issue summary:

View changes

Comment #25

xjm

she/her

English

commented 25 September 2015 at 17:11

I filed #2575081: [policy, no patch] Use E_USER_DEPRECATED in Drupal 8 minor releases. Go theme team!

Comment #26

davidhernandez

English

USA

commented 29 September 2015 at 00:52

Title:	[META-8 theme functions left] Convert/refactor core theme functions	» [META-7 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Comment #27

star-szr

he/him

English

commented 1 October 2015 at 19:17

Issue summary:

View changes

Swapping the theme_indentation() refactor issue for a simpler one. We may actually be rid of core theme functions by release!

Comment #28

star-szr

he/him

English

commented 5 October 2015 at 13:15

Title:	[META-7 theme functions left] Convert/refactor core theme functions	» [META-4 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

One of them is not quite committed (pushed) yet but 3 more down! \m/

Comment #29

star-szr

he/him

English

commented 5 October 2015 at 13:16

Issue summary:

View changes

Comment #30

rainbowarray

she/her

English

Twin Cities, Minnesota

commented 6 October 2015 at 06:07

Title:	[META-4 theme functions left] Convert/refactor core theme functions	» [META-3 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Comment #31

star-szr

he/him

English

commented 7 October 2015 at 10:56

Title:	[META-3 theme functions left] Convert/refactor core theme functions	» [META-2 theme functions left] Convert/refactor core theme functions
Issue summary:	View changes

Only 2 left! Of course it's 2 #type table ones >:(