Problem/Motivation

We want to remove all theme functions from core by RC1.

Proposed resolution

Convert/refactor the remaining theme functions in the sub-issues.

Remaining child/grandchild issues (higher priority issues at the top)

Theme function name Issue/next steps
theme_field_ui_table #1938900: Convert theme_field_ui_table into a template
theme_language_content_settings_table #1938912: Convert language content setting table theme to a twig template

Completed

-

Theme function name Completed Issue
theme_system_modules_uninstall #2151113: Convert theme_system_modules_uninstall() to Twig
theme_system_modules_details #2151109: Convert theme_system_modules_details() to Twig
theme_authorize_message #1885564: theme.maintenance.inc (authorize.php) - Convert theme_ functions to Twig
theme_authorize_report
theme_views_ui_build_group_filter_form #1963978: Convert theme_views_ui_build_group_filter_form() to Twig
theme_book_link #2443361: Remove theme_book_link, make book tree align with MenuLinkTree build
theme_responsive_image_formatter #1898442: responsive_image.module - Convert theme_ functions to Twig
theme_book_admin_table #1968982: Convert book theme tables to table #type
theme_locale_translate_edit_form_strings #1938916: Convert locale theme tables to table #type
theme_menu_overview_form #1938918: Convert menu theme tables to table #type Assigned to: botanic_spark
theme_node_search_admin #1938920: Convert node_search_admin theme tables to table #type
theme_system_compact_link #1833932: Convert theme_system_compact_link() into a #type link
theme_views_view_fields #2348747: Convert theme_views_view_fields() to 100% Twig: remove the theme function
theme_views_view_field #2348729: Convert theme_views_view_field to twig
theme_indentation #2578567: Remove theme_indentation() and use Twig template only
theme_language_negotiation_configure_browser_form_table #2422481: Convert language negotiation theme table to table #type

The total count of remaining (not including test functions) theme functions in core is displayed in the issue title. The following search can be run in ack 2.x to get the current number:

ack 'function theme_[^(]+\([^$]*(\$variables)*\) ?{' --ignore-dir=core/modules/system/tests core | wc -l

Remove the | wc -l to get a list of the remaining theme functions.

User interface changes

n/a

API changes

Theme functions will be removed.

Comments

Cottser’s picture

Issue summary: View changes
Manuel Garcia’s picture

Manuel Garcia’s picture

Cottser’s picture

Issue summary: View changes
joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

Title: [META-20 theme functions left] Convert/refactor core theme functions » [META-17 theme functions left] Convert/refactor core theme functions
Issue summary: View changes

Splitting off the complete issues. 3 more down;) 17 to go!

Cottser’s picture

Title: [META-17 theme functions left] Convert/refactor core theme functions » [META-16 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
Cottser’s picture

Issue summary: View changes
Cottser’s picture

Issue summary: View changes
Cottser’s picture

Title: [META-16 theme functions left] Convert/refactor core theme functions » [META-15 theme functions left] Convert/refactor core theme functions
Issue summary: View changes

Hmm, somehow we have an off by one error in the ack command. Time for trusty ol' wc -l :)

Cottser’s picture

Title: [META-15 theme functions left] Convert/refactor core theme functions » [META-13 theme functions left] Convert/refactor core theme functions
Issue summary: View changes

Thank you #2260061: Responsive image module does not support sizes/picture polyfill 2.2! Just one theme function left now in responsive_image.module.

Manuel Garcia’s picture

Issue summary: View changes
Cottser’s picture

Issue summary: View changes

Separating out the higher priority issues from the things we can live with being theme functions in 8.0.0 :)

Cottser’s picture

Issue summary: View changes

Swapping theme_views_view_fields() and theme_views_view_field().

Cottser’s picture

Title: [META-13 theme functions left] Convert/refactor core theme functions » [META-12 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
Cottser’s picture

Title: [META-12 theme functions left] Convert/refactor core theme functions » [META-11 theme functions left] Convert/refactor core theme functions
Cottser’s picture

Issue summary: View changes

Moving down to completed.

Cottser’s picture

Title: [META-11 theme functions left] Convert/refactor core theme functions » [META-10 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
joelpittet’s picture

Title: [META-10 theme functions left] Convert/refactor core theme functions » [META-8 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
joelpittet’s picture

Issue summary: View changes
joelpittet’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
akalata’s picture

Issue summary: View changes
xjm’s picture

davidhernandez’s picture

Title: [META-8 theme functions left] Convert/refactor core theme functions » [META-7 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
Cottser’s picture

Issue summary: View changes

Swapping the theme_indentation() refactor issue for a simpler one. We may actually be rid of core theme functions by release!

Cottser’s picture

Title: [META-7 theme functions left] Convert/refactor core theme functions » [META-4 theme functions left] Convert/refactor core theme functions
Issue summary: View changes

One of them is not quite committed (pushed) yet but 3 more down! \m/

Cottser’s picture

Issue summary: View changes
mdrummond’s picture

Title: [META-4 theme functions left] Convert/refactor core theme functions » [META-3 theme functions left] Convert/refactor core theme functions
Issue summary: View changes
Cottser’s picture

Title: [META-3 theme functions left] Convert/refactor core theme functions » [META-2 theme functions left] Convert/refactor core theme functions
Issue summary: View changes

Only 2 left! Of course it's 2 #type table ones >:(

joelpittet’s picture

Issue tags: +rc target triage
joelpittet’s picture

Both RTBC!, Edit well no but they should be:)

catch’s picture

Issue tags: -rc target triage +rc target

Agreed with the other committers this is RC target.

joelpittet’s picture

Status: Active » Fixed

Woo Fixed!

Cottser’s picture

Title: [META-2 theme functions left] Convert/refactor core theme functions » [META-0 theme functions left] Convert/refactor core theme functions

:D :D :D :D :D :D

akalata’s picture

Whoo!

sqndr’s picture

Nice work everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.