Derivatives uses the same key so ignored

CommentFileSizeAuthor
#8 2347053-8.patch1.64 KBandypost
#8 2347053-8-fail.patch905 bytesandypost
#3 Screenshot from 2014-12-12 13:02:05.png33.65 KBswentel
fix.patch772 bytesandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs tests
swentel’s picture

swentel commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2014-12-12 13:02:05.png33.65 KB

Wondering whether we really need tests.

also the local taks is still called field settings, we should probably rename that to storage settings for consistency.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

There's an issue open somewhere where they are trying to rename that, current patches are renaming it to "Global settings" or so...

andypost’s picture

andypost
he/him
Primary language Russian
commented

So what to do with the issue?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Related issues: +#1855002: "Field settings" tab needs renaming to "Field storage settings"

That's the issue: #1855002: "Field settings" tab needs renaming to "Field storage settings"

amateescu’s picture

amateescu commented

I'd propose to leave the renaming of the local task label to the issue mentioned by @Berdir above, but we still need to add a small test here.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2347053-8-fail.patch905 bytes
new 2347053-8.patch1.64 KB

Here's it

The last submitted patch, 8: 2347053-8-fail.patch, failed testing.

amateescu’s picture

amateescu commented
Title: Field UI tabs derivatives are build wrong » "Field settings" local task from Field UI is missing
Status: Needs review » Reviewed & tested by the community

Awesome! Thanks :)

  • catch committed fcb5df2 on 8.0.x 
    Issue #2347053 by andypost, swentel: "Field settings" local task from...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.