Problem/Motivation

1. When updates are available, the status message does not include 'Drupal core' but the name of the first enabled extension of core, e.g. 'Block'.
2. When at the same time updates are available for one extension (e.g. Drupal core) and no updates are available for an other extension (e.g a dev-release of a module) the 'Update translations' button is not shown.

To reproduce:

  1. Install D8 from Git
  2. Enable Language module and add one language (admin/config/regional/language)
  3. Install and enable git deploy module, dev release (https://www.drupal.org/project/git_deploy).
  4. Enable Interface translation module
  5. Go to Interface translation status page (admin/reports/translations)
  6. Click 'Check manually' (admin/reports/translations/check).
  7. Observe "Updates for: Block" (should be "Drupal core")
  8. Observe: Missing button "Update translations"

Proposed resolution

  • Recreate the issue
    Wrong update message
  • Solve and post patch
  • Test the patch
    Message after patch
  • Post pictures and report back

Remaining tasks

n/a

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#19 resolved error display message.PNG11.3 KBzerdiox
#16 error.PNG10.76 KBzerdiox
#1 2346629-interface-translation-interface-1.patch4.13 KBsutharsan
#1 2346629-interface-translation-interface-1-test-only.patch2.81 KBsutharsan

Comments

sutharsan’s picture

sutharsan commented
Assigned: sutharsan » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2346629-interface-translation-interface-1-test-only.patch2.81 KB
new 2346629-interface-translation-interface-1.patch4.13 KB

The last submitted patch, 1: 2346629-interface-translation-interface-1-test-only.patch, failed testing.

sutharsan’s picture

sutharsan commented
Issue summary: View changes
broon’s picture

broon
Location Potsdam
commented

Not sure if related, but on my 8.0.0-alpha15+123-dev (today, 12:44) status report shows 

Drupal core update status	Unsupported release
Your version of Drupal is no longer supported. Upgrading is strongly recommended! See the available updates page for more information and to install your missing updates.

However, available updates page shows: All of your projects are up to date.

When clicking "Check manually", the progress bar briefly pops up (only thing I can read is "Checking available ... for BLOCK") and still it's reporting that everything is up to date (even with patch applied). So, this might not be a pure translation issue.

broon’s picture

broon
Location Potsdam
commented

However, I can confirm, that the patch resolves the translation error on the update translations page (changing display from "Updates for: Block" to "Updates for: Drupal".

sutharsan’s picture

sutharsan commented

@Paul, If you use a Git checkout of Drupal 8 and use Git Deploy module, you will get the alpha15 translation.

sutharsan’s picture

sutharsan commented
Issue summary: View changes
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Code and tests looks good to me. If manual testing is succesful we can RTBC.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented

I can't reproduce, because when I go to "Check translation status manually", after that I see an success message (Nothing to check.)

sutharsan’s picture

sutharsan commented
Issue summary: View changes
sutharsan’s picture

sutharsan commented

I have re-checked and made small changes to the steps to reproduce the error.

zerdiox’s picture

zerdiox commented

Testing this now.

zerdiox’s picture

zerdiox commented
Issue summary: View changes

I'm done testing and followed the steps. At first I didn't observe Updates for: Block or the missing button. But I also skipped the fifth step those times. Last time I didn't skip step 5 and also installed a new language, this way I did get the desired observations.

Further I edited the summary to include the link to the language-add page and clarified step 3 to also enable the git_deploy module.

penyaskito manual testing looks good so we could possibly push this to RTBC?

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Big y es from me, thanks!

zerdiox’s picture

zerdiox commented

I repeated my testing after applying the patch just to be sure and I did get Updates for: Drupal core. So it works as intended.

zerdiox’s picture

zerdiox commented
StatusFileSize
new error.PNG10.76 KB

To make things more clear this is the image of the observed error.
error in interface

zerdiox’s picture

zerdiox commented
Issue summary: View changes
zerdiox’s picture

zerdiox commented
Title: Two Interface translation interface errors » When on report translations page, wrong update messages displayed.
zerdiox’s picture

zerdiox commented
StatusFileSize
new resolved error display message.PNG11.3 KB

Picture of the result of the patch.

Result after patch

zerdiox’s picture

zerdiox commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 365358c and pushed to 8.0.x. Thanks!

  • alexpott committed 365358c on 8.0.x 
    Issue #2346629 by Sutharsan: Fixed When on report translations page,...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.