Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
routing system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Sep 2014 at 15:35 UTC
Updated:
13 Oct 2014 at 14:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerFirst bit, conversions are done in the repo at the same time.
Comment #2
Crell commentedSet https to false by default in addOptionsDefault() and this check can go away.
buildQuery() is documented as unneeded as of PHP 5.4, which is now a required version anyway. Per its docblock we can just use http_build_query() directly and eliminate the dependency.
Should this method also enforce legal values? Eg, that absolute and https can only be booleans and nothing else?
Since those methods are internal to one particular implementation this comment is inappropriate on the interface.
Comment #3
alexpottIf you do #2.2 you will need to use the PHP_QUERY_RFC3986 constant.
Comment #4
dawehnerActually not because we handle three cases:
Well, if people add new (non-existing) options and they are not doing anything I am not convinced that it is worth the effort
both in term of more complexity in the code and performance.
Originally I though this would be a great idea, though yeah this is just another level of discussion (do we still want to help the old wrapper etc.) Let's do that in another place, sorry.
Comment #7
pwolanin commentedLooks like dawehner included changes from the next part of the patch. Let me try to roll this again.
Comment #8
pwolanin commentedComment #9
pwolanin commentedre: UrlHelper::buildQuery(), it's not that simple - I have a patch that made it a wrapper on the built-in and it does somewhat different encoding than Drupal core does, so making such a change in this patch would likely generate pointless test fails all over.
see: #2248257: Optimize UrlHelper::buildQuery() to use http_build_query()
Comment #10
Crell commented"split up", not splitted.
Otherwise, if we're not fixing UrlHelper here then this seems fine.
Comment #11
pwolanin commentedok, fixed that code comment.
Comment #12
dawehnerCool
Comment #13
alexpottDurpal :) cheeky.
Nok? I think this is Nor
I think both of these should be fixed on commit. I'm +1 for rtbc.
Comment #14
webchickFixed Alex's nits and committed and pushed to 8.x. Thanks!
Comment #17
webchickSilly testbot, trix are for kids.
Comment #18
xjm