diff --git a/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php b/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php index 1730e9e..6d19da3 100644 --- a/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php +++ b/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php @@ -41,6 +41,9 @@ public function __construct(RequestStack $request_stack, ConfigFactoryInterface /** * {@inheritdoc} + * + * This is a helper function that calls buildExternalUrl() or buildLocalUrl() + * based on a check of whether the path is a valid external URL. */ public function assemble($uri, array $options = []) { // Note that UrlHelper::isExternal will return FALSE if the $uri has a diff --git a/core/lib/Drupal/Core/Utility/UnroutedUrlAssemblerInterface.php b/core/lib/Drupal/Core/Utility/UnroutedUrlAssemblerInterface.php index 4eacd20..d8d0e64 100644 --- a/core/lib/Drupal/Core/Utility/UnroutedUrlAssemblerInterface.php +++ b/core/lib/Drupal/Core/Utility/UnroutedUrlAssemblerInterface.php @@ -14,8 +14,8 @@ /** * Builds a domain-local or external URL from a path or URL. * - * This is a helper function that calls buildExternalUrl() or buildLocalUrl() - * based on a check of whether the path is a valid external URL. + * For actual implementations the logic probably has to be splitted up + * between domain-local and external URLs. * * @param string $uri * A path on the same domain or external URL being linked to, such as "foo" diff --git a/core/tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php b/core/tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php index 5b4dd8d..492fb79 100644 --- a/core/tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php +++ b/core/tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php @@ -33,10 +33,15 @@ class UnroutedUrlAssemblerTest extends UnitTestCase { protected $configFactory; /** + * The tested unrouted url assembler. + * * @var \Drupal\Core\Utility\UnroutedUrlAssembler */ protected $unroutedUrlAssembler; + /** + * {@inheritdoc} + */ protected function setUp() { parent::setUp();