Closed (fixed)
Project:
Internationalization
Version:
7.x-1.x-dev
Component:
Menus
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2014 at 07:49 UTC
Updated:
5 Nov 2016 at 20:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
co.kazemi commentedHi I found the problem was because of the text group field in the translation table. When we add translations for a menu item, it saves row with "menu" for the text group field. So it shows rightly translated item in menu place. But for admin overview Drupal use default (built in interface). I use a _i18n_menu_link_title function to solve it. Apply patch to i18n_menu. module to test this patch.
Comment #2
sinasalek commentedThe format of the patch is incorrect, also the patch has a side effect
Menu items that are added using for example views that before applying the patch were appearing translated , appear untranslated.
For reproducing it try adding items to menu using views menu settings and then translate it using i18nviews
Comment #3
co.kazemi commentedEverything goes right. Check it again, please.
Comment #4
sinasalek commented#2345843: menu admin overview page is not translated admin/structure/menu Marked as duplicate of this
Comment #5
sinasalek commentedThe approach generally seems correct, however there is sort of a logical problem here. title_callback for menu items that are link to specific pages within site almost always is not empty. However if we skip checking title_callback and always try to translate the title, what will happen to title_callback? It think that it's not important because title_callback is for the page title i guess and not the menu name.
In our case in recent version of the Drupal and our particular use case that patch #1 seems to be working fine. It would be great if someone with more knowledge about i18n review that patch.
Comment #6
sinasalek commentedComment #8
sinasalek commentedPatch reroll and still works
Comment #10
sinasalek commentedComment #11
sinasalek commentedComment #13
sinasalek commentedComment #14
sinasalek commentedComment #15
joseph.olstadseems like a reasonable patch, maybe put it in dev after pending release
Comment #17
joseph.olstadfixed in dev branch, let this simmer in dev for a while.