Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Update module was converted to OO in issue #1987888: Convert update_manual_status() to a new style controller. update_parse_xml() was transformed into UpdateProcessor::parseXml() but its code was left over. It is not used in any part of core (neither in drush btw).
Remaining tasks:
- Review Change Notice
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2345371-remove_function_update_parse_xml-8.patch | 2.54 KB | estoyausente |
| #1 | 2345371-remove_function_update_parse_xml.patch | 1.91 KB | jonhattan |
Comments
Comment #1
jonhattanComment #2
jonhattanComment #3
penyaskitoNice catch, looks good.
I think we need a change record for this. Probably we can group the CR with #2306437: Remove update_fetch_data_batch
Comment #4
penyaskitoTag
Comment #5
penyaskitoTagging for the sprints.
Comment #6
estoyausenteI'm trying to do this, I usually make of a wrong way the patchs -.-"
Comment #7
estoyausenteComment #8
estoyausenteNow. I group both issues, I'm not sure if on the correct way ^^.
Comment #9
estoyausenteComment #10
chandeepkhosa commentedlooked at patch, its removing just the functions it needs to and not too much [had help from YesCT too]
Comment #12
herom commentedComment #13
penyaskitoDon't we need a change record for this, as requested in #2306437: Remove update_fetch_data_batch? Sorry if I was not clear, but in #3 I asked to make a grouped Change Record, not to merge both issues :-(
Comment #14
estoyausente@penyaskito Oh, I understood merge both issues... What can we do for resolve it?
Comment #15
penyaskitoUpdated title accordingly and updated summary with the novice tasks template with instructions about how to create a change record. Also closed the other issue as fixed.
Comment #16
art124 commentedComment #17
cilefen commentedNeeds review of the change notice.
Comment #18
cilefen commentedBack to fixed.
Comment #19
penyaskito