Update module was converted to OO in issue #1987888: Convert update_manual_status() to a new style controller. update_parse_xml() was transformed into UpdateProcessor::parseXml() but its code was left over. It is not used in any part of core (neither in drush btw).

Remaining tasks:

  • Review Change Notice
CommentFileSizeAuthor
#8 2345371-remove_function_update_parse_xml-8.patch2.54 KBestoyausente
#6 2345371-remove_function_update_parse_xml-6.patch2.54 KBestoyausente
#1 2345371-remove_function_update_parse_xml.patch1.91 KBjonhattan

Comments

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
StatusFileSize
new 2345371-remove_function_update_parse_xml.patch1.91 KB
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Needs work
Related issues: +#2306437: Remove update_fetch_data_batch

Nice catch, looks good.
I think we need a change record for this. Probably we can group the CR with #2306437: Remove update_fetch_data_batch

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Needs change record

Tag

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Novice

Tagging for the sprints.

estoyausente’s picture

estoyausente
Primary language Spanish
commented
Assigned: Unassigned » estoyausente
StatusFileSize
new 2345371-remove_function_update_parse_xml-6.patch2.54 KB

I'm trying to do this, I usually make of a wrong way the patchs -.-"

estoyausente’s picture

estoyausente
Primary language Spanish
commented
estoyausente’s picture

estoyausente
Primary language Spanish
commented
Status: Needs work » Needs review
StatusFileSize
new 2345371-remove_function_update_parse_xml-8.patch2.54 KB

Now. I group both issues, I'm not sure if on the correct way ^^.

estoyausente’s picture

estoyausente
Primary language Spanish
commented
Issue tags: +Amsterdam2014
chandeepkhosa’s picture

chandeepkhosa commented
Status: Needs review » Reviewed & tested by the community

looked at patch, its removing just the functions it needs to and not too much [had help from YesCT too]

  • catch committed f0b9aeb on 8.0.x 
    Issue #2345371 by estoyausente, jonhattan: Remove unused...
herom’s picture

herom commented
Status: Reviewed & tested by the community » Fixed
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Don't we need a change record for this, as requested in #2306437: Remove update_fetch_data_batch? Sorry if I was not clear, but in #3 I asked to make a grouped Change Record, not to merge both issues :-(

estoyausente’s picture

estoyausente
Primary language Spanish
commented

@penyaskito Oh, I understood merge both issues... What can we do for resolve it?

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Remove unused update_parse_xml() » Change Notice: Remove unused update_parse_xml() and update_fetch_data_batch()
Issue summary: View changes
Status: Fixed » Active

Updated title accordingly and updated summary with the novice tasks template with instructions about how to create a change record. Also closed the other issue as fixed.

art124’s picture

art124 commented
Issue summary: View changes
Issue tags: -Needs change record
cilefen’s picture

cilefen commented
Status: Active » Needs review

Needs review of the change notice.

cilefen’s picture

cilefen commented
Status: Needs review » Fixed

Back to fixed.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Change Notice: Remove unused update_parse_xml() and update_fetch_data_batch() » Remove unused update_parse_xml() and update_fetch_data_batch()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.