#2313757: Remove text_processing option from text fields, expose existing string field types as plain text in UI has split the "text" field types between string* (raw strings) and text* (formatted text).
For consistency, the 'list_text' field type, that is only about unformatted strings, should be renamed list_string.

This is if we don't end up doing #2342581: Merge list field types into main field types. Since this is still being discussed and has no patch, and doing the rename should happen before the beta, posting a patch for this here.
Published change notice and added class rename info too

CommentFileSizeAuthor
#1 2344979-rename_list_text-1.patch13.76 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
2344979-rename_list_text-1.patch13.76 KB

Patch does :
- field type : list_text --> list_string
- class: ListTextItem --> ListStringItem
- Human readable label is left unchanged, since #2313757: Remove text_processing option from text fields, expose existing string field types as plain text in UI kept "Text" for string* and text* field types.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

makes sense

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Patch looks great + confirmed that zero occurrences of list_text remain when the patch is applied.

RTBC+1

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed d56b70c on 8.0.x 
    Issue #2344979 by yched: Rename field type list_text to list_string.
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
CreditAttribution: anavarre commented

Programmatically update your custom YML files:

$ cd /path/to/custommodule/config/install/
$ grep -lir "list_text" * | xargs -i@ sed -i "s/list_text/list_string/I" @
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Change record? Maybe part of the one about text/string split-up?

yched’s picture

yched CreditAttribution: yched commented

- Change record created
- added a link to it in the CR about the text/string split-up (see diff)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
yched’s picture

yched CreditAttribution: yched commented

@larowlan: thanks, lost the habit of publishing CRs :-)
Adjusted the part about the class rename, since it only affects D8-to-D8

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.