Javascript leaks id globally [#2343555]

In flexslider.load.js 'id' variable is leaking to the global object by mistake:
for (id in settings.flexslider.instances) {

This caused a rare collision with other custom javasript that was also doing something wrong with global object.

Comment	File	Size	Author
#1	id_leaked_globally-flexslider-2343555-1.patch	458 bytes	miroslavbanov

Comments

miroslavbanov commented 23 September 2014 at 15:27

Status:

Active

» Needs review

Status	File	Size
new	id_leaked_globally-flexslider-2343555-1.patch	458 bytes

This patch fixes the problem by initializing id in local scope.

minoroffense commented 30 July 2015 at 19:58

Status:

Needs review

» Fixed

30 July 2015 at 19:58

minorOffense committed 2cfaff4 on 7.x-2.x authored by MiroslavBanov

Issue #2343555 by MiroslavBanov: Javascript leaks id globally

13 August 2015 at 20:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.