The checkboxes should be used to remove the strings. Maybe replace them with X graphics ("remove"), apply some AJAX and have it use JavaScript to hide the item? Might be overkill, but hey!

CommentFileSizeAuthor
#7 stringoverrides_checkbox_usability_4.patch5.96 KBRobLoach
#6 stringoverrides_checkbox_usability_3.patch5.44 KBRobLoach
#5 stringoverrides_checkbox_usability_2.patch4.75 KBRobLoach
#3 stringoverrides_checkbox_usability.patch4.26 KBRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zilla’s picture

zilla CreditAttribution: zilla commented

why would you need a checkbox? couldn't you simply copy what's on the left into the box on the right and then save - then you'll have an inventory of things you have changedthat you may want to change again...

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

I was talking with John (clouseau), and he suggested adding a "Remove disabled" button at the bottom of the page that would remove the strings that are un-checked. Hitting the Save button wouldn't remove any items, it would just "disable" the string items that arn't checked.

This means that although we can keep the enabled strings in "locale_custom_strings_en", we'll have to hold the disabled strings somewhere else. Maybe "locale_custom_disabled_strings_en"?

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Needs review
FileSize
stringoverrides_checkbox_usability.patch4.26 KB

With this patch, users can disable strings without removing them. There's an addition button at the bottom to "Remove disabled" strings. Testing appreciated.

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented

While this is an improvement, I think the checkbox column needs to be labeled "Enabled" so the user knows what the meaning of that column is.

Also, the form should be generated with a test for whether there are any existing strings. If there are no existing strings, the checkbox column and the Remove disabled button could be suppressed. Sadly, "Remove disabled" is not very clear either. Does it mean that clicking the button will disable the Remove feature? Or remove the disabled...what? Maybe "Remove disabled strings" would be clearer.

Likewise, the "More strings" button is unclear. Am I going to get some random strings that Drupal will generate for me? How about "Add row" instead, since that's what it actually does?

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Needs work
FileSize
stringoverrides_checkbox_usability_2.patch4.75 KB

Hi John! Thanks for checking this out. I made some of those changes, but really have to go. So, this is a work in progress.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Assigned: Unassigned » RobLoach
Status: Needs work » Needs review
FileSize
stringoverrides_checkbox_usability_3.patch5.44 KB

This is looking good now....

I'm not sure I like how "Enabled" looks in the table header row. It pushes the text fields to the right and makes it look like the columns are misaligned. I also like having the ability to select all the rows at the same time. Letting the user know what the checkboxes are for is important though, and I'm no usability expert, so I think it's your call, John.

Any thoughts? A search for theme('table_select_header_cell') will allow you to play with the Enabled column.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
FileSize
stringoverrides_checkbox_usability_4.patch5.96 KB

There we go. Centering the column makes it look a bit better.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Needs review » Patch (to be ported)

Decided to commit this as it really improves usability. Thanks a lot for the ideas, John! http://drupal.org/cvs?commit=115775

If anyone wants to backport it to the Drupal 5 branch, please feel free to hit up a patch.

If 6.x-1.x-dev looks okay with you, John, I'd like to push a 1.7 release with this feature.

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented

Rob, 6.x-1.x-dev does not seem to be saving my strings. I installed the module, entered some strings, clicked the add row button, entered another string, and clicked Save configuration, but although the message tells me "Your changes have been saved", they have not been saved.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

What browser are you using? Are you on a PHP 5 server?

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented

Safari 3.1.1. Yes.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Category: feature » bug
Priority: Normal » Critical
Status: Patch (to be ported) » Active

Hmmm, very strange. I'll have a look to see what we took out that could be negatively effecting the forms.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Postponed (maintainer needs more info)

I can't replicate what you're experiencing in either Firefox/Gecko on Ubuntu Hardy, or Internet Explorer 7 on Windows.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Postponed (maintainer needs more info) » Fixed

I'm pushing my luck with the 1.7 release, as it includes this patch.

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented

Using Safari 3.1.2 I am not able to replicate the problem I was having earlier. So,cool!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.