CommentFileSizeAuthor
#3 2342557-google-variable-support-3.patch3.98 KBkiwimind
#2 2342557-google-variable-support.patch4.51 KBkiwimind
#1 google_tag_variable_support_2.patch2.11 KBAnonymous (not verified)
google_tag_variable_support.patch1.84 KBtharna

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new google_tag_variable_support_2.patch2.11 KB

Hi. Cool idea! I corrected this patch a little. I added domain_variable support and corrected regexp on validate container ID variable.

kiwimind’s picture

kiwimind commented
StatusFileSize
new 2342557-google-variable-support.patch4.51 KB

I've taken this a step further by rewriting and ensuring that all variables are available to be added via the variable configuration.

There is no validation on the tag (yet). Should be simple to implement.

Could also be improved by altering titles and/or description text.

kiwimind’s picture

kiwimind commented
StatusFileSize
new 2342557-google-variable-support-3.patch3.98 KB

Apologies, some issues with that last patch.

Have amended the following:

- removed defaults that read form variable_get and added sensible hardcoded values from admin.inc
- required settings removed as they don't make sense
- enabled types replaced with select types

jeffm2001’s picture

jeffm2001 commented
Status: Needs review » Reviewed & tested by the community

This patch works great. Thanks!

  • solotandem committed 21351ca on 7.x-1.x 
    Issue #2342557: Add support for variable module.

Allow module to be...
solotandem’s picture

solotandem commented
Assigned: Unassigned » solotandem
Status: Reviewed & tested by the community » Fixed

Please test latest release. Thanks.

  • solotandem committed 21351ca on 8.x-1.x 
    Issue #2342557: Add support for variable module.

Allow module to be...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.