CommentFileSizeAuthor
#9 consider-other-media-too-2341297-9.patch1.55 KBjunaidpv
#3 ckeditor_media_youtube_submit_does_nothing_2341297-3.patch559 byteshamrant
#1 ckeditor_media_youtube_submit_does_nothing_2341297.patch517 bytesgfed

Comments

gfed’s picture

gfed commented
StatusFileSize
new ckeditor_media_youtube_submit_does_nothing_2341297.patch517 bytes
harris_david’s picture

harris_david commented

I tried this patch after experiencing something that appeared to be the same issue. In the CKEditor, I can add a youtube video, but with I hit the submit button it does nothing. However, the patch did not work for me. The error I'm getting (before and after the patch) is this:

TypeError: 'undefined' is not an object (evaluating 'imgElement.attributes')

hamrant’s picture

hamrant commented
Version: 7.x-1.x-dev » 7.x-1.16
Issue summary: View changes
StatusFileSize
new ckeditor_media_youtube_submit_does_nothing_2341297-3.patch559 bytes

I have the same problem and the patch also did not work for me. Here's my solution to the problem.

hamrant’s picture

hamrant commented

Tested on ckeditor 7.x-1.16 + media 7.x-1.5 + media_oembed 7.x-2.3

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 7.x-1.16 » 7.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

#3 looks good. Let's have it.

podarok queued 3: ckeditor_media_youtube_submit_does_nothing_2341297-3.patch for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to RTBC

junaidpv’s picture

junaidpv
Location Kannur, Kerala
commented

@harris_david may be you need to install media_wysiwyg module.

junaidpv’s picture

junaidpv
Location Kannur, Kerala
commented
StatusFileSize
new consider-other-media-too-2341297-9.patch1.55 KB

Here is the improved patch. jQuery's `is()` function can have comma separated tag names. Consider the newly added tags while stripping also. Updated nearby comments as well.

jcisio’s picture

jcisio commented
Status: Reviewed & tested by the community » Closed (won't fix)

Media integration has been moved to another module.

junaidpv’s picture

junaidpv
Location Kannur, Kerala
commented

For those who wondering, the new integration module to glue media with ckeditor is media_ckeditor.