Function apachesolr_index_get_entities_to_index() still accesses the old 'apachesolr_read_only' variable which became an apachesolr_environment_variable. This is causing multiple issues.

CommentFileSizeAuthor
#1 2338591_apachesolr_index_get_entities_to_index_randomly_fails.patch1.87 KBmkalkbrenner

Comments

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new 2338591_apachesolr_index_get_entities_to_index_randomly_fails.patch1.87 KB

I additionally removed some obsolete code from apachesolr_search_uninstall() related to variables that become environment specific.

  • mkalkbrenner committed 3962960 on 6.x-3.x 
    Issue #2338591 by mkalkbrenner: apachesolr_index_get_entities_to_index...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Version: 6.x-3.x-dev » 7.x-1.x-dev

I just noticed that this issue affects 7.x-1.x as well. The patch applies unmodified.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

This patch just fixes some parts we missed in #1953976: avoid use variable_set() in anything related to indexing content (because of performance) and should be applied quickly.
The worst case this issue can cause is to update entities on a read-only environment.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed

Committed to 7.x-1.x

  • mkalkbrenner committed bf60c72 on 7.x-1.x 
    Issue #2338591 by mkalkbrenner: apachesolr_index_get_entities_to_index...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.