Problem/Motivation

The UrlAlias destination had the fields missed when it was committed.

  /**
   * {@inheritdoc}
   */
  public function fields(MigrationInterface $migration = NULL) {
    // TODO: Implement fields() method.
  }

Proposed resolution

Add them

Remaining tasks

Review/Commit

User interface changes

n/a

API changes

n/a

CommentFileSizeAuthor
#1 interdiff.txt610 bytesbenjy
#1 2338085-2.patch690 bytesbenjy
alias-dest-1.patch659 bytesbenjy

Comments

benjy’s picture

benjy commented
StatusFileSize
new 2338085-2.patch690 bytes
new interdiff.txt610 bytes

Added pid.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

I would say let's commit this and hope one day AliasStorage comes out of the stone age and converts to db_merge so that even if you supply a pid it will save something...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Seems weird that there are not any tests?

benjy’s picture

benjy commented

The method isn't used right now, it's just there for when we add the UI.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6f0b27b and pushed to 8.0.x. Thanks!

  • alexpott committed 6f0b27b on 8.0.x 
    Issue #2338085 by benjy: Fixed UrlAlias Destination is missing fields...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.