Problem/Motivation

Tiny part of #2226533: Changes to the Language class due to the LanguageInterface (followup) but not central to that issue.

Language locked is a boolean

Proposed resolution

use TRUE FALSE not 0

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Novice Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Novice Instructions

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#11 language_locked_is_a-2337827-11.patch456 bytescolbol
#9 language_locked_is_a-2337827-9.patch456 bytescilefen

Comments

yesct’s picture

yesct commented
Status: Needs review » Active

+++ b/core/lib/Drupal/Core/Language/Language.php
@@ -26,7 +26,7 @@ class Language implements LanguageInterface {
'name' => 'English',
'direction' => self::DIRECTION_LTR,
'weight' => 0,
- 'locked' => 0,
+ 'locked' => FALSE,
'default' => TRUE,
);

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Novice

I guess this is a good task for Novice.

yesct’s picture

yesct commented
Issue summary: View changes
Issue tags: -Novice

yep. adding instructions.

yesct’s picture

yesct commented
Issue summary: View changes
Issue tags: +Novice

oops

yesct’s picture

yesct commented
Issue summary: View changes

oops html in summary.

yesct’s picture

yesct commented
Issue summary: View changes
yesct’s picture

yesct commented
Issue summary: View changes
cilefen’s picture

cilefen commented
Assigned: Unassigned » cilefen

I am mentoring someone through this.

cilefen’s picture

cilefen commented
Status: Active » Needs review
StatusFileSize
new language_locked_is_a-2337827-9.patch456 bytes

Druplicon thinks my mentee colbol is a bot (d.o. issue has been opened on that) so I am posting the patch for him and explaining how.

Suggested commit message: "Issue #2337827 by colbol | YesCT: Language locked is a boolean, use TRUE FALSE not 0."

yesct’s picture

yesct commented

fixed #2337925: Request for 'not a spammer' role

colbol’s picture

colbol commented
StatusFileSize
new language_locked_is_a-2337827-11.patch456 bytes
yesct’s picture

yesct commented
Assigned: cilefen » Unassigned
Status: Needs review » Reviewed & tested by the community

super! read the patch. no unintended changes and does what is needed. as long as it is green, should be good to go.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d96020c and pushed to 8.0.x. Thanks!

  • alexpott committed d96020c on 8.0.x 
    Issue #2337827 by colbol, cilefen | YesCT: Language locked is a boolean...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.