Problem/Motivation

form_state_values_clean() is one of the few non-theming, non-batch functions left in form.inc
It definitely belongs on FormState

Proposed resolution

Move to FormState

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 interdiff.txt5.29 KBtim.plunkett
#4 2337709-form_state_values_clean-4.patch14.87 KBtim.plunkett
#1 2337709-form_state_values_clean-1.patch10.42 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2337709-form_state_values_clean-1.patch10.42 KB

I thought I was done with this file, but I missed a spot.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Great cleanup

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Let's remove all instances of form_state_values_clean() from comments too so the followup issue will just remove the function. I've linked this issue to the general CR.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2337709-form_state_values_clean-4.patch14.87 KB
new interdiff.txt5.29 KB

Good point. Just docs fixes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 179e7c2 and pushed to 8.0.x. Thanks!

  • alexpott committed 179e7c2 on 8.0.x 
    Issue #2337709 by tim.plunkett: Convert form_state_values_clean() to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.