Rename 'branding' to 'content-header'

Here's a patch.

Sure, if its just killing that single ID :) Here's an updated patch.

So then branding.css needs to be renamed or merged to another css file

Submitting a patch .

How do we rename files using a patch in Drupal? Delete old + create new? Or anything like "git mv"?

It seems patch #7 just deletes branding.css without merging the content or creating a new file called content-header.css

..

my interdiff is made from the patch in comment 3, and ignoring the last patch

updated issue tags to include amsterdam2014

@derjochenmeyer : I usedgit mv core/themes/seven/css/components/branding.css core/themes/seven/css/components/content-header.css

You included the sites/default/settings.php file in the patch. Interdiff looks good though ;)

@ChandeepKhosa: Here's your patch without the settings.php file.

Screenshot of the Seven content header region.

Changed status to trigger the bot.

I've applied the patch and cleared my caches and the region is not displaying correctly, see screenshot.

We will work on it, and provide a new patch.

Hey up, working on a fix to this.

fix needed to yml file also, which will need to be added to the patch.

Change in info file, CSS changes and rename, and updated twig template.

Setting to needs review then, thanks skippednote

(For information, patch naming conventions can be found here - this makes it easier to match up a downloaded patch with the issue queue again :] )

Fixed missing file issues with the patch.

Resubmitting as the last patch was empty.

Just a note that jchin1968, roborew, stephen-cox, kiliweb and lwilliams came up with the same patch as well independently.

I am at the drupalcon sprint amsterdam and try to review this right now.

#33 looks good to me.

content-header.css

seven.info.yml

page.html.twig

Here is a new patch with the UnitTest updated made with roborew, stephen-cox and jchin1968.

Changes :
1) Renaming branding.css to content-header.css
2) Change the selectors of theses files : page-title.css, tabs.css, content-header.css
3) Inclue content-header.css in the seven.info.yml file
4) Update the test to check the existence of content-header.css instead of branding.css

Tested patch #42 and it works well.

Here's a re-roll

Ah, good eyes! Here's a new one.

Adjusted issue summary.

+++ b/core/themes/seven/css/components/content-header.css
@@ -0,0 +1,11 @@
+[dir="rtl"] .content-header {
+  padding: 20px 20px 0 20px;
+}

This part wasn't needed anymore. The original rule in branding.css was removed in #2343281: Fix RTL issues in content listing page, aka /admin/content.

Good catch @herom. I've tested your patch. Looks good, and does what it says. Here's a screenshot where the change can be seen.

+1

Committed 539ff30 and pushed to 8.0.x. Thanks!