Problem/Motivation

There are a couple places in Views where a form_state key is called '#page_title'

Proposed resolution

Switch that to just 'page_title'

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 drupal8-Replace-Views-page-title-2336483-5.patch1.38 KBpushpinderchauhan

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Postponed

Lets wait on #2335659: Remove FormState ArrayAccess usage from core.

gerzenstl’s picture

gerzenstl commented

Sure, I checked from where came the hashtag on the key. But lets wait for #2335659.

gerzenstl’s picture

gerzenstl commented
Assigned: Unassigned » gerzenstl
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Postponed » Needs work

This is good to go!

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-Replace-Views-page-title-2336483-5.patch1.38 KB

Please review attached patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Thanks! I hope @gerzenstl doesn't mind...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 01d3221 and pushed to 8.0.x. Thanks!

  • alexpott committed 01d3221 on 8.0.x 
    Issue #2336483 by er.pushpinderrana | tim.plunkett: Replace Views $...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.