Adding custom Wrapper CSS classes removes the "form-item" class [#2336445]

I am observing that when I add a custom class in the "Wrapper CSS classes" field in a form component settings, then the default class "form-item" gets removed and replaced by the new class.
In some previous version this behaviour was a little different: the new class was simply being added ("form-item"
was not being removed).

Is this the desired behaviour or is it a bug?

Comment	File	Size	Author
#2	webform-adding_custom_wrapper-2336445-1.patch	1.01 KB	DanChadwick
#2
	Custom-class-removes-form-item.JPG	46.58 KB	arx-e
	Custom-class-removes-form-item-code.JPG	65.4 KB	arx-e

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

10 September 2014 at 21:12

DanChadwick committed dea4be1 on 7.x-4.x

Issue #2336445 by DanChadwick: Fixed Adding custom Wrapper CSS classes...

Comment #2

DanChadwick CreditAttribution: DanChadwick commented 10 September 2014 at 21:14

Status:

Active

» Fixed

File	Size
webform-adding_custom_wrapper-2336445-1.patch	1.01 KB

Yes it's a bug. Oddly it was already fixed in 8.x in what looks to be a bit of code cleanup..

Committed to 7.x-4.x (only).

Comment #3

arx-e CreditAttribution: arx-e commented 11 September 2014 at 07:41

Thank you Dan!

Comment #4

kevinedmister CreditAttribution: kevinedmister commented 11 September 2014 at 19:38

The Patch from #2 fixes the issue and fixes conditionals breaking because of the missing classes.

Comment #5

DanChadwick CreditAttribution: DanChadwick commented 11 September 2014 at 20:22

Picked up the 7-10 split, I guess. Is there an issue for the conditional/custom wrapper class issue?

Comment #6

25 September 2014 at 20:31

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #7

rsacher1 CreditAttribution: rsacher1 commented 2 April 2015 at 09:54

Using webform-7.x-4.7

A custom CSS can be applied as Wrapper - showing up in code.

On next time opening that field in Webform-Designer the Wrapper-Field is empty - resulting in overwriting the first custom CSS with "" - so custom CSS is lost on next save.